Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
thisisnic commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2804306938 Hey @PeopleMakeCulture - as this has been open a while without a PR, I'm gonna grab it, hope you don't mind! (Also, hey Jing, didn't realise this is you, see you at RC in a few weeks hopefully!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
AlenkaF commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2804642772 Issue resolved by pull request 46144 https://github.com/apache/arrow/pull/46144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
rok commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2152909955 @PeopleMakeCulture the documentation PR is welcome, feel free to open a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
PeopleMakeCulture commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2152774710 I would like to claim this issue if it's still available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
felipecrv commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2118253093 @jorisvandenbossche perhaps `*ListArray` and `FixedSizeListArray` need a `sliced_values()` accessor. For list-views `sliced_values` would be hard to compute and explain to users though (because offsets are not necessarily sorted in list-views). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Python][Doc] Clarify docstring of FixedSizeListArray.values that it ignores the offset [arrow]
felipecrv commented on issue #41672: URL: https://github.com/apache/arrow/issues/41672#issuecomment-2118248448 > Of course, that reason is not important for `FixedSizeListArray` given there are no offsets in this case... Technically the offsets exist the same way, but are implicit because they can be computed with `(arr.offset + i) * list_size`. Child arrays of nested layouts are required to keep the prefix-padding on the buffer when an upper level `.offset > 0` to make it so that slicing an array, doesn't have to slice recursively. This makes the zero-copy `.values` that @pvardanis wants to do, a bit trickier, but on the other hand makes slicing arrays constant-time instead of O(depth_of_the_layout) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
