Re: [I] Faster json reader [arrow-rs]
tustvold commented on issue #7273:
URL: https://github.com/apache/arrow-rs/issues/7273#issuecomment-2715480669
I believe this codepath is only hit when coercing integer to strings, e.g.
```
{"a": 123}
```
Reading into a StringArray column
So any benchmark would need to be doing this in order to see improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [I] Faster json reader [arrow-rs]
alamb commented on issue #7273: URL: https://github.com/apache/arrow-rs/issues/7273#issuecomment-2715191257 BTW it may turn out that the suggested change doesn't improve performance -- but we can measure with the benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Faster json reader [arrow-rs]
alamb commented on issue #7273: URL: https://github.com/apache/arrow-rs/issues/7273#issuecomment-2715190155 You can run the json reader benchmark here: ```rust cargo bench --bench json_reader ``` and compare before/after performance Since this is well specified I think this would be a good first issue for anyone who wants to learn about low level rust optimization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
