Re: [PR] [DNM] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]

2025-06-13 Thread via GitHub 


hiroyuki-sato commented on PR #46795:
URL: https://github.com/apache/arrow/pull/46795#issuecomment-2969385590

   The latest version is completely the same which is previous version. CI 
failure last time, but now passed.
   
   [C# / AMD64 macOS 13 C# 8.0.x 
(pull_request)](https://github.com/apache/arrow/actions/runs/15628195841/job/44026360248?pr=46795)[C#
 / AMD64 macOS 13 C# 8.0.x 
(pull_request)](https://github.com/apache/arrow/actions/runs/15628195841/job/44026360248?pr=46795)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [DNM] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]

2025-06-12 Thread via GitHub 


hiroyuki-sato commented on PR #46795:
URL: https://github.com/apache/arrow/pull/46795#issuecomment-2969241588

   "C# / AMD64 macOS 13 C# 8.0.x (pull_request)" succeed just added two `echo` 
statements.
   
https://github.com/apache/arrow/actions/runs/15627712157/job/44025027456?pr=46795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [DNM] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]

2025-06-12 Thread via GitHub 


hiroyuki-sato commented on PR #46795:
URL: https://github.com/apache/arrow/pull/46795#issuecomment-2969165159

   I confirmed that "C# / AMD64 macOS 13 C# 8.0.x (pull_request)" error relates 
to this PR.
   
   Build passed without this change.
   https://github.com/apache/arrow/actions/runs/15625785800/job/44019635324
   
   
   I'm not sure why this change cause error yet.
   
   ```diff
   diff --git a/ci/scripts/csharp_test.sh b/ci/scripts/csharp_test.sh
   index a435a83525..f521afc01d 100755
   --- a/ci/scripts/csharp_test.sh
   +++ b/ci/scripts/csharp_test.sh
   @@ -30,8 +30,9 @@ if [ -z "${PYTHON}" ]; then
  fi
fi
${PYTHON} -m pip install pyarrow find-libpython
   -export PYTHONNET_PYDLL=$(${PYTHON} -m find_libpython)
   +PYTHONNET_PYDLL=$(${PYTHON} -m find_libpython)
   +export PYTHONNET_PYDLL
   
   -pushd ${source_dir}
   +pushd "${source_dir}"
dotnet test
popd
   ```
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]