Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
alinaliBQ commented on PR #46099: URL: https://github.com/apache/arrow/pull/46099#issuecomment-2914028789 @kou Yes, our team can look into https://github.com/apache/arrow/issues/46576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
alinaliBQ commented on code in PR #46099: URL: https://github.com/apache/arrow/pull/46099#discussion_r2110235970 ## dev/release/rat_exclude_files.txt: ## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: Sure, I have added headers in `.cmd` and `.def` file, and removed them from the rat exclusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
kou commented on code in PR #46099: URL: https://github.com/apache/arrow/pull/46099#discussion_r2106130835 ## dev/release/rat_exclude_files.txt: ## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: Could you add license header to all files expect that don't support comment. We can use `rem ...` in `.cmd` and `; ...` in `.dev` for comments. ## dev/release/rat_exclude_files.txt: ## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: Could you add license header to all files expect that don't support comment? We can use `rem ...` in `.cmd` and `; ...` in `.dev` for comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
kou commented on PR #46099: URL: https://github.com/apache/arrow/pull/46099#issuecomment-2907695044 Could you fix a build error https://github.com/apache/arrow/issues/46576 before the ODBC layer development? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
lidavidm commented on PR #46099: URL: https://github.com/apache/arrow/pull/46099#issuecomment-2906452898 OK - sounds good, please ping me when that is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
alinaliBQ commented on code in PR #46099: URL: https://github.com/apache/arrow/pull/46099#discussion_r2105524260 ## dev/release/rat_exclude_files.txt: ## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: The Apache Ignite [install_amd64.cmd](https://github.com/apache/ignite/blob/927ead13979937195aca6ffb717942fb477dc1b6/modules/platforms/cpp/odbc/install/install_amd64.cmd) file does not have a license on it, so I assume `.cmd` files don't need licenses. Same reason for `.def` files; the Apache Ignite [module.def](https://github.com/apache/ignite/blob/38a4804/modules/platforms/cpp/odbc/module.def) file does not have a license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
alinaliBQ commented on code in PR #46099: URL: https://github.com/apache/arrow/pull/46099#discussion_r2105524260 ## dev/release/rat_exclude_files.txt: ## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: The Apache Ignite [install_amd64.cmd](https://github.com/apache/ignite/blob/927ead13979937195aca6ffb717942fb477dc1b6/modules/platforms/cpp/odbc/install/install_amd64.cmd) file does not have a license on it, so I assume `.cmd` files don't need licenses. Same logic for `.def` files; the Apache Ignite [module.def](https://github.com/apache/ignite/blob/38a4804/modules/platforms/cpp/odbc/module.def) file does not have a license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
alinaliBQ commented on PR #46099: URL: https://github.com/apache/arrow/pull/46099#issuecomment-2905420610 Hi David @lidavidm and Kou @kou, there's been a change regarding my last comment, we (Rob @rscales & I) will still work on splitting the PR into smaller ones and look into the `flightsql-odbc` comments from David on https://github.com/apache/arrow/pull/40939 (and any other comments for Arrow ODBC Flight SQL), but that will be after we finish developing the ODBC layer to have the full functionality. This PR#40939 will stay in draft state until we finish developing the ODBC driver, but any changes in this PR are ready for community to review. TL;DR, we would like to finish the ODBC layer development first, and we will begin addressing the community comments after that. Please let me know if you have any questions. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-30622: [C++] Arrow Flight SQL ODBC layer [arrow]
github-actions[bot] commented on PR #46099: URL: https://github.com/apache/arrow/pull/46099#issuecomment-2905341124 :warning: GitHub issue #30622 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
