Re: [PR] GH-38903: [R][Docs] Improve documentation of col_types [arrow]
conbench-apache-arrow[bot] commented on PR #46145: URL: https://github.com/apache/arrow/pull/46145#issuecomment-2824526116 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 486670a7266cf6f49d0b7cc0209359332b27572a. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/41020218084) has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-38903: [R][Docs] Improve documentation of col_types [arrow]
thisisnic merged PR #46145: URL: https://github.com/apache/arrow/pull/46145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-38903: [R][Docs] Improve documentation of col_types [arrow]
thisisnic commented on code in PR #46145: URL: https://github.com/apache/arrow/pull/46145#discussion_r2054497564 ## r/R/dataset.R: ## @@ -248,17 +248,24 @@ open_dataset <- function(sources, #' # Set up directory for examples #' tf <- tempfile() #' dir.create(tf) +#' on.exit(unlink(tf)) Review Comment: Deleted now, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-38903: [R][Docs] Improve documentation of col_types [arrow]
jonkeane commented on code in PR #46145: URL: https://github.com/apache/arrow/pull/46145#discussion_r2050876640 ## r/R/dataset.R: ## @@ -248,17 +248,24 @@ open_dataset <- function(sources, #' # Set up directory for examples #' tf <- tempfile() #' dir.create(tf) +#' on.exit(unlink(tf)) Review Comment: I know it was down below, but since this is a tempfile, we technically don't need to clean it up, right? It'll be deleted when the process ends regardless -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-38903: [R][Docs] Improve documentation of col_types [arrow]
github-actions[bot] commented on PR #46145: URL: https://github.com/apache/arrow/pull/46145#issuecomment-2804474066 :warning: GitHub issue #38903 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
