Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
conbench-apache-arrow[bot] commented on PR #43439: URL: https://github.com/apache/arrow/pull/43439#issuecomment-2916594021 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b5b670f753253fe11d3ccd460d150049. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/43048441653) has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
kou commented on PR #43439: URL: https://github.com/apache/arrow/pull/43439#issuecomment-2914566618 @raulcd We're ready to split `swift/`! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
kou merged PR #43439: URL: https://github.com/apache/arrow/pull/43439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
kou commented on code in PR #43439:
URL: https://github.com/apache/arrow/pull/43439#discussion_r2107172645
##
swift/Arrow/Sources/Arrow/ArrowWriterHelper.swift:
##
@@ -25,85 +25,90 @@ extension Data {
}
func toFBTypeEnum(_ arrowType: ArrowType) ->
Result {
-let infoType = arrowType.info
-if infoType == ArrowType.ArrowInt8 || infoType == ArrowType.ArrowInt16 ||
-infoType == ArrowType.ArrowInt64 || infoType == ArrowType.ArrowUInt8 ||
-infoType == ArrowType.ArrowUInt16 || infoType == ArrowType.ArrowUInt32
||
-infoType == ArrowType.ArrowUInt64 || infoType == ArrowType.ArrowInt32 {
+let typeId = arrowType.id
+switch arrowType.id {
Review Comment:
```suggestion
switch typeId {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
kou commented on PR #43439: URL: https://github.com/apache/arrow/pull/43439#issuecomment-2903638779 @abandy Sorry. I forgot this PR. Could you rebase on main? Let's merge this before we move `swift/` to apache/arrow-swift. Cc: @raulcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
raulcd commented on PR #43439: URL: https://github.com/apache/arrow/pull/43439#issuecomment-2903667951 Thanks for the ping @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
kou commented on code in PR #43439:
URL: https://github.com/apache/arrow/pull/43439#discussion_r1694434336
##
swift/Arrow/Sources/Arrow/ArrowWriter.swift:
##
@@ -71,11 +71,30 @@ public class ArrowWriter { // swiftlint:disable:this
type_body_length
public init() {}
private func writeField(_ fbb: inout FlatBufferBuilder, field: ArrowField)
-> Result {
+var fieldsOffset: Offset?
+if let nestedField = field.type as? ArrowNestedType {
+var offsets = [Offset]()
+for field in nestedField.fields {
+switch writeField(&fbb, field: field) {
+case .success(let offset):
+offsets.append(offset)
+case .failure(let error):
+return .failure(error)
+}
+}
+
+fieldsOffset = fbb.createVector(ofOffsets: offsets)
+}
+
let nameOffset = fbb.create(string: field.name)
let fieldTypeOffsetResult = toFBType(&fbb, arrowType: field.type)
let startOffset = org_apache_arrow_flatbuf_Field.startField(&fbb)
org_apache_arrow_flatbuf_Field.add(name: nameOffset, &fbb)
org_apache_arrow_flatbuf_Field.add(nullable: field.isNullable, &fbb)
+if let childOffset = fieldsOffset {
+org_apache_arrow_flatbuf_Field.addVectorOf(children: childOffset,
&fbb)
Review Comment:
`childrenOffset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-43170: [Swift] Add StructArray support to ArrowWriter [arrow]
github-actions[bot] commented on PR #43439: URL: https://github.com/apache/arrow/pull/43439#issuecomment-2253600939 :warning: GitHub issue #43170 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
