Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2727309836 Hi @pitrou. Sorry for the delayed response. I am reviewing my changes and sharing my observations below. I searched for crossbow builds for Windows jobs before this commit but it seems only builds within the past 10 days can be seen so I am not sure if this issue existed even before merging this pull request. I also searched for recent builds and came across these two https://github.com/ursacomputing/crossbow/actions/runs/13694461790/job/38293655589 https://github.com/ursacomputing/crossbow/actions/runs/13806992326/job/38619753752 where the logs looked different from the one in https://github.com/ursacomputing/crossbow/actions/runs/12992305572/job/36231835900 I searched `arc unarchive tzdata.tar.xz` in my local repo and I see that this line is in `ci/scripts/python_wheel_windows_test.bat`  I checked the main branch now and this line is removed as seen [here](https://github.com/apache/arrow/blob/main/ci/scripts/python_wheel_windows_test.bat) I did not make any changes to `ci/scripts/python_wheel_windows_test.bat` in my commit so I am unable to find out what resulted in the error in the screenshot shared in your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323:
URL: https://github.com/apache/arrow/pull/45323#issuecomment-2711221504
It seems we made a mistake when merging this: the Crossbow builds stop
before running the PyArrow tests:
https://github.com/ursacomputing/crossbow/actions/runs/12992305572/job/36231835900
```
C:\>arc unarchive tzdata.tar.xz
C:\Users\ContainerAdministrator\Downloads\test\tzdata || exit /B
VALUE: &archiver.TarXz{Tar:(*archiver.Tar)(0xc64720)}
scanning source archive: wrapping reader: xz: file format not recognized
```
For some reason, the builds were still marked successful, which is why we
didn't notice :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2621410350 "The wheel still _loads_ on a system without msvcp140.dll installed" means exactly that. It has nothing to do with _creating_ the wheel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2621401546 As you mentioned that the someone should check if the wheel still loads on a system without msvcp140.dll installed, I interpreted it as an expectation that the wheel can be created on a machine which does not have msvcp140.dll installed. Is this incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2621376860 > Someone should check that the wheel still loads on a system without msvcp140.dll installed. I can try to do that using Docker at some point. @pitrou Does this mean that msvcp140.dll is not mandatory to create the wheel? I thought maybe some sort of if-else can be implemented in the .bat file to check if msvcp140.dll is already installed. If it isn't, then then it can be manually installed like this. Would this also work? https://github.com/apache/arrow/blob/f4a63d41ebbc57566f215c1d1e87fc1647071dae/ci/scripts/python_wheel_windows_build.bat#L30-L33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2621382811 > @pitrou Does this mean that msvcp140.dll is not mandatory to create the wheel? I don't understand what you mean here, can you clarify the question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
conbench-apache-arrow[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2617212009 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2eba03f1cb80b2611c89d9e0672fab4233472aef. There were 8 benchmark results with an error: - Commit Run on `amd64-m5-4xlarge-linux` at [2025-01-27 18:15:58Z](https://conbench.ursa.dev/compare/runs/5d442a1b39b04b029c2608cdedff7bb6...0df2beadcc8f44fb9c2efddbc5b246e0/) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1](https://conbench.ursa.dev/benchmark-results/06797f68f434723e8000ea3a257a9716) - [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1](https://conbench.ursa.dev/benchmark-results/06797f69c402780480002498385e66ba) - and 6 more (see the report linked below) There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/36258367764) has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2616396192 Thanks @protokoul for your first contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd merged PR #45323: URL: https://github.com/apache/arrow/pull/45323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2616058800 Revision: 4cb4791fb41cd4d130949bad45f72f775301f24d Submitted crossbow builds: [ursacomputing/crossbow @ actions-708fedca9b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-708fedca9b) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992305724/job/36231836297)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992306087/job/36231837835)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992305584/job/36231835917)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992305572/job/36231835900)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992305617/job/36231835918)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12992305563/job/36231835885)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323:
URL: https://github.com/apache/arrow/pull/45323#issuecomment-2616095035
Ok, it seems to work with the Crossbow-generated wheel above:
```pycon
Python 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64
bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import ctypes
>>> ctypes.CDLL('msvcp140.dll')
Traceback (most recent call last):
File "", line 1, in
File "C:\Python\lib\ctypes\__init__.py", line 374, in __init__
self._handle = _dlopen(self._name, mode)
FileNotFoundError: Could not find module 'msvcp140.dll' (or one of its
dependencies). Try using the full path with constructor syntax.
>>> import pyarrow as pa
>>> pa.show_info()
pyarrow version info
Package kind : python-wheel-windows
Arrow C++ library version : 20.0.0-SNAPSHOT
Arrow C++ compiler: MSVC 19.28.29336.0
Arrow C++ compiler flags : /DWIN32 /D_WINDOWS /GR /EHsc
/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING /EHsc /wd5105 /bigobj /utf-8 /W3
/wd4800 /wd4996 /wd4065 /MP
Arrow C++ git revision: 4cb4791fb41cd4d130949bad45f72f775301f24d
Arrow C++ git description :
Arrow C++ build type : release
[...]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2616052824 @github-actions crossbow submit wheel-windows* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2615567725 Someone should check that the wheel still loads on a system without msvcp140.dll installed. I can try to do that using Docker at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2613243821 @github-actions crossbow submit wheel-windows-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2613247201 Revision: 4cb4791fb41cd4d130949bad45f72f775301f24d Submitted crossbow builds: [ursacomputing/crossbow @ actions-b334eba5b6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b334eba5b6) |Task|Status| ||--| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12956350671/job/36142421782)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2607489410 Thank you @raulcd for reviewing the changes and helping with the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
pitrou commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2607433061 > @pitrou from what I understand we were manually upgrading it because the system provided one was an old version, is this an issue that prevents us from using the released `delvewheel`? As long as we're using the same one that we've built against, it should be ok. > I suppose the solution would be to build our own Image and use a newer Microsoft Runtime Library but that's a bigger effort. Definitely, but it's desirable anyway: https://github.com/apache/arrow/issues/45156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2607163904 Revision: 657d9710794ed54ebf253777df81b578c7c81d85 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3a4d87d41c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3a4d87d41c) |Task|Status| ||--| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12908549651/job/35994306508)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2607158927 @github-actions crossbow submit wheel-windows-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323:
URL: https://github.com/apache/arrow/pull/45323#issuecomment-2606724119
Great! This seems to work but it's copying the dll on `pyarrow.libs/` an
this was not expected to be previously:
```
C:\>C:\Python39\python
C:\arrow\ci\scripts\python_wheel_validate_contents.py --path
C:\arrow\python\repaired_wheels || exit /B 1
Traceback (most recent call last):
File "C:\arrow\ci\scripts\python_wheel_validate_contents.py", line 48, in
main()
File "C:\arrow\ci\scripts\python_wheel_validate_contents.py", line 44, in
main
validate_wheel(args.path)
File "C:\arrow\ci\scripts\python_wheel_validate_contents.py", line 35, in
validate_wheel
assert not outliers, f"Unexpected contents in wheel: {sorted(outliers)}"
AssertionError: Unexpected contents in wheel: ['pyarrow.libs/',
'pyarrow.libs/.load-order-pyarrow-20.0.0.dev14',
'pyarrow.libs/msvcp140-a4b2ab3dc6cde85d4f2c0e24432d66e1.dll']
```
We might want to update our `python_wheel_validate_contents.py` script to
allow this folder to be available on the Windows wheel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605855755 Revision: 4135fb950b2d05b9e76a305ee09592f894e81a44 Submitted crossbow builds: [ursacomputing/crossbow @ actions-13055f6c30](https://github.com/ursacomputing/crossbow/branches/all?query=actions-13055f6c30) |Task|Status| ||--| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12896929935/job/35960978656)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605852463 @github-actions crossbow submit wheel-windows-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605455855 Sure, let me push this change. Also, would it be better if I also add `delvewheel show` as discussed [here](https://github.com/apache/arrow/pull/35323#discussion_r1890443378) if it helps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605438968 From what I understand this is currently not mangling `msvcp40.dll` because we are copying it on the wheel. I think we have to remove this copy: https://github.com/apache/arrow/blob/4ede48c89b8ec80bbd1895357f272c5fb61bc9b6/ci/scripts/python_wheel_windows_build.bat#L136-L137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605337904 Revision: d7c2e4817569c55fb613bb0dc359a005f70a46d1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c8bb220277](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c8bb220277) |Task|Status| ||--| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12892424409/job/35946602506)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-260535 @github-actions crossbow submit wheel-windows-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
protokoul commented on code in PR #45323:
URL: https://github.com/apache/arrow/pull/45323#discussion_r1924111204
##
ci/scripts/python_wheel_windows_build.bat:
##
@@ -144,16 +144,13 @@ cp C:\Windows\System32\msvcp140.dll pyarrow\
@REM Since we bundled the Arrow C++ libraries ourselves, we only need to
@REM mangle msvcp140.dll so as to avoid ABI issues when msvcp140.dll is
@REM required by multiple Python libraries in the same process.
-@REM
-@REM For now this requires a custom version of delvewheel:
-@REM https://github.com/adang1345/delvewheel/pull/59
-%PYTHON_CMD% -m pip install
https://github.com/pitrou/delvewheel/archive/refs/heads/fixes-for-arrow.zip ||
exit /B 1
+%PYTHON_CMD% -m pip install delvewheel || exit /B 1
for /f %%i in ('dir dist\pyarrow-*.whl /B') do (set WHEEL_NAME=%cd%\dist\%%i)
|| exit /B 1
echo "Wheel name: %WHEEL_NAME%"
%PYTHON_CMD% -m delvewheel repair -vv ^
---mangle-only=msvcp140.dll --no-patch ^
+--ignore-existing --with-mangle=msvcp140.dll ^
Review Comment:
I have removed it and pushed latest changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on code in PR #45323:
URL: https://github.com/apache/arrow/pull/45323#discussion_r1924076100
##
ci/scripts/python_wheel_windows_build.bat:
##
@@ -144,16 +144,13 @@ cp C:\Windows\System32\msvcp140.dll pyarrow\
@REM Since we bundled the Arrow C++ libraries ourselves, we only need to
@REM mangle msvcp140.dll so as to avoid ABI issues when msvcp140.dll is
@REM required by multiple Python libraries in the same process.
-@REM
-@REM For now this requires a custom version of delvewheel:
-@REM https://github.com/adang1345/delvewheel/pull/59
-%PYTHON_CMD% -m pip install
https://github.com/pitrou/delvewheel/archive/refs/heads/fixes-for-arrow.zip ||
exit /B 1
+%PYTHON_CMD% -m pip install delvewheel || exit /B 1
for /f %%i in ('dir dist\pyarrow-*.whl /B') do (set WHEEL_NAME=%cd%\dist\%%i)
|| exit /B 1
echo "Wheel name: %WHEEL_NAME%"
%PYTHON_CMD% -m delvewheel repair -vv ^
---mangle-only=msvcp140.dll --no-patch ^
+--ignore-existing --with-mangle=msvcp140.dll ^
Review Comment:
The above should solve the current failure:
```
C:\arrow\python>C:\Python39\python -m delvewheel repair -vv
--ignore-existing --with-mangle=msvcp140.dll -w repaired_wheels
C:\arrow\python\dist\pyarrow-20.0.0.dev12-cp39-cp39-win_amd64.whl || exit /B
1
usage: __main__.py repair [-h] [--add-path PATHS] [--include DLLS]
[--exclude DLLS] [--ignore-existing]
[--analyze-existing] [-v] [-w TARGET]
[--no-mangle DLLS] [--no-mangle-all |
--with-mangle]
[--strip] [-L LIB_SDIR]
[--namespace-pkg PKGS | --custom-patch]
[--include-symbols] [--include-imports]
wheel [wheel ...]
__main__.py repair: error: argument --with-mangle: ignored explicit argument
'msvcp140.dll'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on code in PR #45323:
URL: https://github.com/apache/arrow/pull/45323#discussion_r1924074015
##
ci/scripts/python_wheel_windows_build.bat:
##
@@ -144,16 +144,13 @@ cp C:\Windows\System32\msvcp140.dll pyarrow\
@REM Since we bundled the Arrow C++ libraries ourselves, we only need to
@REM mangle msvcp140.dll so as to avoid ABI issues when msvcp140.dll is
@REM required by multiple Python libraries in the same process.
-@REM
-@REM For now this requires a custom version of delvewheel:
-@REM https://github.com/adang1345/delvewheel/pull/59
-%PYTHON_CMD% -m pip install
https://github.com/pitrou/delvewheel/archive/refs/heads/fixes-for-arrow.zip ||
exit /B 1
+%PYTHON_CMD% -m pip install delvewheel || exit /B 1
for /f %%i in ('dir dist\pyarrow-*.whl /B') do (set WHEEL_NAME=%cd%\dist\%%i)
|| exit /B 1
echo "Wheel name: %WHEEL_NAME%"
%PYTHON_CMD% -m delvewheel repair -vv ^
---mangle-only=msvcp140.dll --no-patch ^
+--ignore-existing --with-mangle=msvcp140.dll ^
Review Comment:
with mangle is supposed to be used without arguments and should search any
dll which is not already part of the wheel.
```suggestion
--ignore-existing --with-mangle ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605158108 Revision: 9308397ee5b1b6b8975d12b3e2983c9fe6b31416 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3fbb6f8b60](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3fbb6f8b60) |Task|Status| ||--| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12891040154/job/35942045132)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
raulcd commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605152097 @github-actions crossbow submit wheel-windows-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-45278: [Python][Packaging] Updated delvewheel install command and updated flags used with delvewheel repair [arrow]
github-actions[bot] commented on PR #45323: URL: https://github.com/apache/arrow/pull/45323#issuecomment-2605130677 :warning: GitHub issue #45278 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
