Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
mgorny commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2805305960 Closing since this is unlikely to get merged as-is, and #45854 seems like the future direction. I can look into implementing something at meson level once it gets merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
mgorny closed pull request #45580: GH-45576: [Python] Support building C++ library automatically URL: https://github.com/apache/arrow/pull/45580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
mgorny commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2729851729 Gentle ping. Would it be acceptable to do something like this at CMake level instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
mgorny commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2681651182 > I understand the appeal but this will still fail for people building from source from pypi for example Well, that's definitely something that could be fixed as a followup, or at least to some degree. > were to move our build-backend to [scikit-build-core](https://github.com/scikit-build/scikit-build-core) Well, I'm all for that. I suppose a similar solution (i.e. ability to build Arrow C++ libraries from the Python build) could also be implemented at CMake level, and actually that's how I initially wanted to do it — but I've given up since it required a lot of added complexity. I've noted the problems in #45576. I'm not saying it's impossible, just would probably involve more changes to CMake files and more work, and I'm not sure if that is desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
pitrou commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2681486896 > I think the current plan, or at least the latest conversations, were to move our build-backend to [scikit-build-core](https://github.com/scikit-build/scikit-build-core). Yes, IMHO that's very much where we want to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
raulcd commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2681482048 I think the current plan, or at least the latest conversations, were to move our build-backend to [scikit-build-core](https://github.com/scikit-build/scikit-build-core). Adding more custom options to our `setup.py` seems that will make that migration even more complex. I understand the appeal but this will still fail for people building from source from pypi for example and only helps downstream package maintainers that want to build pyarrow from source cloning the repo, right? which at that point requires a couple commands to build Arrow C++: ```bash cmake -S arrow/cpp -B arrow/cpp/build \ -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \ --preset ninja-release-python cmake --build arrow/cpp/build --target install ``` @tiran when you say your downstream builds are much easier to maintain, could you share a link on how are you currently building Arrow C++? Is that you would like to get rid of the manual cmake commands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
pitrou commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2678760814 I'm frankly not sure we want to support anything like this. Our `setup.py` is already tedious to maintain and we probably don't want to add any complexity there. @raulcd @jorisvandenbossche Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
tiran commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2671769881 I have tested @mgorny 's PR in our downstream build pipeline. It was as intended and makes our downstream builds much easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45576: [Python] Support building C++ library automatically [arrow]
github-actions[bot] commented on PR #45580: URL: https://github.com/apache/arrow/pull/45580#issuecomment-2669628027 :warning: GitHub issue #45576 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
