Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
conbench-apache-arrow[bot] commented on PR #45699: URL: https://github.com/apache/arrow/pull/45699#issuecomment-2711151282 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ffd651a1298a7e7f97aad83aa51f636d80fe46a3. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/38504917748) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
raulcd merged PR #45699: URL: https://github.com/apache/arrow/pull/45699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
kou commented on PR #45699: URL: https://github.com/apache/arrow/pull/45699#issuecomment-2708040451 > We also have to update the release process to change this script so we don't trigger the crossbow jobs or are you planning to update this as a follow up? > https://github.com/apache/arrow/blob/main/dev/release/07-binary-verify.sh Right. Let's work on it as a follow up task: https://github.com/apache/arrow/issues/45708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
kou commented on code in PR #45699:
URL: https://github.com/apache/arrow/pull/45699#discussion_r1985993031
##
.github/workflows/verify_rc.yml:
##
@@ -0,0 +1,182 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Verify RC
+
+on:
+ push:
+tags:
+ - "*-rc*"
+
+permissions:
+ contents: read
+
+env:
+ TEST_DEFAULT: "0"
+ VERBOSE: "1"
+
+jobs:
+ apt:
+name: APT
+runs-on: ${{ matrix.runs-on }}
+timeout-minutes: 30
+strategy:
+ fail-fast: false
+ matrix:
+runs-on:
+ - ubuntu-latest
+ - ubuntu-24.04-arm
+env:
+ TEST_APT: "1"
+steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - name: Run
+run: |
+ package_id=${GITHUB_REF_NAME%-rc*}
+ version=${package_id#apache-arrow-}
+ rc=${GITHUB_REF_NAME#*-rc}
+ dev/release/verify-release-candidate.sh ${version} ${rc}
+
+ binary:
+name: Binary
+runs-on: ubuntu-latest
+timeout-minutes: 30
+env:
+ TEST_BINARY: "1"
+steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - name: Run
+run: |
+ package_id=${GITHUB_REF_NAME%-rc*}
+ version=${package_id#apache-arrow-}
+ rc=${GITHUB_REF_NAME#*-rc}
+ dev/release/verify-release-candidate.sh ${version} ${rc}
+
+ wheels-linux:
+name: Wheels Linux
+runs-on: ubuntu-latest
+timeout-minutes: 30
+strategy:
+ fail-fast: false
+ matrix:
+distro:
+ - almalinux-8
+ - conda
+ - ubuntu-22.04
+ - ubuntu-24.04
Review Comment:
Good catch!
I didn't notice the case because the existing jobs don't cover the case.
I've opened an issue for it: https://github.com/apache/arrow/issues/45707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
raulcd commented on code in PR #45699:
URL: https://github.com/apache/arrow/pull/45699#discussion_r1985011510
##
.github/workflows/verify_rc.yml:
##
@@ -0,0 +1,182 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Verify RC
+
+on:
+ push:
+tags:
+ - "*-rc*"
+
+permissions:
+ contents: read
+
+env:
+ TEST_DEFAULT: "0"
+ VERBOSE: "1"
+
+jobs:
+ apt:
+name: APT
+runs-on: ${{ matrix.runs-on }}
+timeout-minutes: 30
+strategy:
+ fail-fast: false
+ matrix:
+runs-on:
+ - ubuntu-latest
+ - ubuntu-24.04-arm
+env:
+ TEST_APT: "1"
+steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - name: Run
+run: |
+ package_id=${GITHUB_REF_NAME%-rc*}
+ version=${package_id#apache-arrow-}
+ rc=${GITHUB_REF_NAME#*-rc}
+ dev/release/verify-release-candidate.sh ${version} ${rc}
+
+ binary:
+name: Binary
+runs-on: ubuntu-latest
+timeout-minutes: 30
+env:
+ TEST_BINARY: "1"
+steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - name: Run
+run: |
+ package_id=${GITHUB_REF_NAME%-rc*}
+ version=${package_id#apache-arrow-}
+ rc=${GITHUB_REF_NAME#*-rc}
+ dev/release/verify-release-candidate.sh ${version} ${rc}
+
+ wheels-linux:
+name: Wheels Linux
+runs-on: ubuntu-latest
+timeout-minutes: 30
+strategy:
+ fail-fast: false
+ matrix:
+distro:
+ - almalinux-8
+ - conda
+ - ubuntu-22.04
+ - ubuntu-24.04
Review Comment:
probably as a follow up issue but should we add aarch64 wheel validation
using the arm GH hosted runners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
kou commented on PR #45699: URL: https://github.com/apache/arrow/pull/45699#issuecomment-2706015077 Tests except Windows wheel: https://github.com/kou/arrow/actions/runs/13716505940 Test for Windows wheel: https://github.com/kou/arrow/actions/runs/13718045168/job/38367035210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45675: [Release] Run binary RC verification jobs in apache/arrow [arrow]
github-actions[bot] commented on PR #45699: URL: https://github.com/apache/arrow/pull/45699#issuecomment-2706013665 :warning: GitHub issue #45675 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
