Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

conbench-apache-arrow[bot] commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2726493079

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have 
been run so far on merge-commit 69682cd5971b8f6652c5f8f243aeb15a386e8b91.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/38821699044) 
has more details. It also includes information about 13 possible false 
positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

kou merged PR #45759:
URL: https://github.com/apache/arrow/pull/45759


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

github-actions[bot] commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2723044967

   Revision: 13eae3e5792cc9107e0491ee5cf78e2bc65ee3bf
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-8735425042](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8735425042)
   
   |Task|Status|
   ||--|
   |preview-docs|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8735425042-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/13847587808/job/38749036301)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

kou commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2723041867

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

amoeba commented on code in PR #45759:
URL: https://github.com/apache/arrow/pull/45759#discussion_r1993674976


##
docs/source/python/filesystems.rst:
##
@@ -295,6 +296,46 @@ some environment variables.
   In contrast to the legacy HDFS filesystem with ``pa.hdfs.connect``, setting
   ``CLASSPATH`` is not optional (pyarrow will not attempt to infer it).
 
+.. _filesystem-azurefs:
+
+Azure Storage File System
+
+
+PyArrow implements natively an Azure filesystem for Azure Blob Storage with or
+without heirarchical namespace enabled.
+
+The :class:`AzureFileSystem` constructor has several options to configure the
+Azure Blob Storage connection (e.g. account name, account key, SAS token, etc).
+
+If neither account_key or sas_token is specified a `DefaultAzureCredential 
`__

Review Comment:
   ```suggestion
   If neither ``account_key`` or ``sas_token`` is specified a 
`DefaultAzureCredential 
`__
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

jabbera commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2722288828

   @amoeba all set. I did notice SubTreeFileSystem in the new file you linked: 
https://github.com/apache/arrow/blob/6b66c842eefec520d391203d205cd91d1ca0dd65/docs/source/python/api/filesystems.rst?plain=1#L45
   
   It doesn't seem to exist in the main content file so I left it, but I'm 
unsure if it will cause an issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

jabbera commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2721219605

   @kou linting errors are all set, first scan of the doc preview looks good to 
me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

amoeba commented on code in PR #45759:
URL: https://github.com/apache/arrow/pull/45759#discussion_r1993673713


##
docs/source/python/filesystems.rst:
##
@@ -295,6 +296,46 @@ some environment variables.
   In contrast to the legacy HDFS filesystem with ``pa.hdfs.connect``, setting
   ``CLASSPATH`` is not optional (pyarrow will not attempt to infer it).
 
+.. _filesystem-azurefs:
+
+Azure Storage File System
+
+
+PyArrow implements natively an Azure filesystem for Azure Blob Storage with or
+without heirarchical namespace enabled.
+
+The :class:`AzureFileSystem` constructor has several options to configure the
+Azure Blob Storage connection (e.g. account name, account key, SAS token, etc).

Review Comment:
   ```suggestion
   Azure Blob Storage connection (e.g. account name, account key, SAS token, 
etc.).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

amoeba commented on code in PR #45759:
URL: https://github.com/apache/arrow/pull/45759#discussion_r1993659735


##
docs/source/python/filesystems.rst:
##
@@ -295,6 +296,46 @@ some environment variables.
   In contrast to the legacy HDFS filesystem with ``pa.hdfs.connect``, setting
   ``CLASSPATH`` is not optional (pyarrow will not attempt to infer it).
 
+.. _filesystem-azurefs:
+
+Azure Storage File System
+

Review Comment:
   ```suggestion
   -
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

jabbera commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2721383549

   Hopefully this bumps the pyarrow results when you google azure storage 
pyarrow. The initial results are incredibly slow from a performance perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

github-actions[bot] commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719881167

   Revision: 4f656a6a21ce787a0cae8608809154b7ec8de4ce
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-6df96eacef](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6df96eacef)
   
   |Task|Status|
   ||--|
   |preview-docs|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-6df96eacef-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/13826989584/job/38683669375)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

kou commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719872445

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

jabbera commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719778949

   @kou, can you poke the bot please to build the sample docs? This is mostly 
github copilot generated but it's not a bad starting point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

github-actions[bot] commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719776754

   ```
   Only contributors can submit requests to this bot. Please ask someone from 
the community for help with getting the first commit in.
   The Archery job run can be found at: 
https://github.com/apache/arrow/actions/runs/13826670914
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

github-actions[bot] commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719776076

   :warning: GitHub issue #45758 **has been automatically assigned in GitHub** 
to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] GH-45758 [Python] Add AzureFileSystem documentation [arrow]

[via GitHub]

jabbera commented on PR #45759:
URL: https://github.com/apache/arrow/pull/45759#issuecomment-2719775978

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org