Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
conbench-apache-arrow[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2848143604 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62c59c23352583980e894a43ec46335c4d55a7e1. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/41567715257) has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
kou merged PR #45830: URL: https://github.com/apache/arrow/pull/45830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2847127794 @kou this ones a bit more complicated, but is a pre-cursor to finishing many of the remaining options. No rush but whenever you have time to review would be greatly appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2846154566 Revision: ca8b22e44dcfbc455e6b32989e8d249fb5c98eec Submitted crossbow builds: [ursacomputing/crossbow @ actions-790622bf88](https://github.com/ursacomputing/crossbow/branches/all?query=actions-790622bf88) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14787360049/job/41518062227)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2846152754 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2844716929 Revision: 6c72216db875ab6720cfa37d0fb365ee2b5e80e7 Submitted crossbow builds: [ursacomputing/crossbow @ actions-046fc3db6a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-046fc3db6a) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14775059575/job/41481720118)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2844714466 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2841893685 Revision: 6c72216db875ab6720cfa37d0fb365ee2b5e80e7 Submitted crossbow builds: [ursacomputing/crossbow @ actions-abb66860a5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-abb66860a5) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14755125133/job/41421349011)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2841887981 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2841881549 Revision: 1cb9b176c60fbcb8a6531d95a7dc19c11c65ff04 Submitted crossbow builds: [ursacomputing/crossbow @ actions-27442c952a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-27442c952a) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14755031477/job/41421035756)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2841875572 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2807782359 I don't believe the test failure is related to the changes made in this PR as it is reproducible with CMake. I opened an issue for it in https://github.com/apache/arrow/issues/46157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2807620623 Revision: db6f5568b4159f0db7e0ed5ec9f05e4f5c4cc2f7 Submitted crossbow builds: [ursacomputing/crossbow @ actions-b82155104d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b82155104d) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14480142582/job/40615152251)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2807616768 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2807464048 Revision: c97bec990621dc463d2c249d95626bc24d994311 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3bb4e7a944](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3bb4e7a944) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14479087166/job/40611812207)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2807457087 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2804952050 Revision: fbc8a687608b622cc91c7efae80e97adb0462d94 Submitted crossbow builds: [ursacomputing/crossbow @ actions-85e80a74d7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-85e80a74d7) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14469873723/job/40580811351)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2804945182 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731104485 :warning: GitHub issue #45829 **has no components**, please add labels for components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731660491 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731665421 Revision: 7b2e4dc5cbc6b886792e0bc3a7b3e4161fde310c Submitted crossbow builds: [ursacomputing/crossbow @ actions-aeb8c84859](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aeb8c84859) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13915873936/job/38938760601)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731551120 Revision: 823e84abec4efbadd32ce02a52de43f59900728f Submitted crossbow builds: [ursacomputing/crossbow @ actions-25d0ef191a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-25d0ef191a) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13915080509/job/38936548350)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on code in PR #45830:
URL: https://github.com/apache/arrow/pull/45830#discussion_r2000147901
##
cpp/src/arrow/compute/meson.build:
##
@@ -0,0 +1,119 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Meson does not allow you to glob for headers to install. See also
+#
https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard
+# install_subdir would be usable if the directory only contained headers
+
+install_headers(
+[
+'api.h',
+'api_scalar.h',
+'api_vector.h',
+'cast.h',
+'exec.h',
+'expression.h',
+'function.h',
+'function_options.h',
+'kernel.h',
+'ordering.h',
+'registry.h',
+'type_fwd.h',
+'util.h',
+],
+subdir: 'arrow/compute',
+)
+
+if needs_compute
+pkg.generate(
+filebase: 'arrow-compute',
+name: 'Apache Arrow Compute',
+description: 'All compute kernels for Apache Arrow',
+requires: ['arrow'],
+)
+endif
+
+arrow_compute_testing_srcs = []
+if needs_testing
+arrow_compute_testing_srcs += files('test_util_internal.cc')
Review Comment:
As an FYI I wrapped these file paths with the `files` function because both
the `compute` and `compute/kernels` configuration would reference this
variable. The `files` function makes it so that the path here remains absolute,
whereas without it usage of this variable in the `compute/kernels`
configuration would refer to the `test_util_internal.cc` module within that
directory.
It may be a good idea to generally wrap all file paths with this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on code in PR #45830:
URL: https://github.com/apache/arrow/pull/45830#discussion_r2000144730
##
cpp/meson.build:
##
@@ -56,7 +56,9 @@ if git_description == ''
git_description = run_command('git', 'describe', '--tags', check:
false).stdout().strip()
endif
+needs_acero = false
Review Comment:
No problem. I added it here since `needs_compute` will eventually depend on
it, but we can add that logic later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731548706 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
kou commented on code in PR #45830:
URL: https://github.com/apache/arrow/pull/45830#discussion_r137895
##
cpp/meson.build:
##
@@ -56,7 +56,9 @@ if git_description == ''
git_description = run_command('git', 'describe', '--tags', check:
false).stdout().strip()
endif
+needs_acero = false
Review Comment:
Can we add this when we add `acero/` directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731108826 Revision: b9983953625b2b6d5139e83f61739113fc796720 Submitted crossbow builds: [ursacomputing/crossbow @ actions-9f53028b84](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9f53028b84) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13911230597/job/38925697978)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731134400 Revision: f292f33d4a00e04b89b66d8ba45775758d2c4601 Submitted crossbow builds: [ursacomputing/crossbow @ actions-168f1b878c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-168f1b878c) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13911458371/job/38926396337)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731103854 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
WillAyd commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731131550 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45829: [C++] Add compute directory to Meson configuration [arrow]
github-actions[bot] commented on PR #45830: URL: https://github.com/apache/arrow/pull/45830#issuecomment-2731104476 :warning: GitHub issue #45829 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
