Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
conbench-apache-arrow[bot] commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2846928984 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 24b0d917221ce3c631361542a875cfd605b9a2c0. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/41536442762) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
kou merged PR #45858: URL: https://github.com/apache/arrow/pull/45858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
kou commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2070971869 ## dev/tasks/tasks.yml: ## @@ -657,7 +657,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROW_USE_CACHE=OFF is for using sccache Review Comment: ```suggestion # ARROW_USE_CCACHE=OFF is for using sccache ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2844975806 Any further comments on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
github-actions[bot] commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2844919571 Revision: 37687628801f6b8b4b891c5460ab876f3d2c72a6 Submitted crossbow builds: [ursacomputing/crossbow @ actions-7ddf751b7b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7ddf751b7b) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14776824083/job/41486836026)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2844915777 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
github-actions[bot] commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2810505704 Revision: 8f646a868e5309f47e0e95f614b0bff8aa42ef41 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1b31b845a1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1b31b845a1) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14500567918/job/40678990281)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2810499226 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021029474
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
Shouldn't we `export` those variables for them to be noticed by the meson
process? Or is it just not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021072800
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
> My knowledge of bash syntax is pretty limited
Same for me... Apparently "being exported" is an attribute that is being set
and inherited accross processes, though I don't see it specified clearly in the
[POSIX
doc](https://pubs.opengroup.org/onlinepubs/009695399/utilities/export.html). Is
it bash-specific? @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2024727068 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROW_USE_CACHE=OFF is for using sccache Review Comment: Yes - instead of using ccache this will use sccache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2025000395 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROW_USE_CACHE=OFF is for using sccache Review Comment: Note that this is from the request in https://github.com/apache/arrow/pull/45858#issuecomment-2741723075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2025024674 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROW_USE_CACHE=OFF is for using sccache Review Comment: Ah, sorry, I misread. Since it's in `dev/tasks/tasks.yml`, not `docker-compose.yml`, it is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2024704581 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROW_USE_CACHE=OFF is for using sccache Review Comment: Does this mean ccache won't be used here? CMake-based docker builds use ccache by default, which is very useful for local development work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
eli-schwartz commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021212646
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
In section 2.12 of the Shell Command Language:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html
The shell execution environment is described as:
> Variables with the export attribute, along with those explicitly exported
for the duration of the command, shall be passed to the utility environment
variables
which works together with the docs you linked for the `export` special
built-in command, that notes that the effect of `export XXX` is to mark the
variable `XXX` with the export attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
eli-schwartz commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021212646
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
In section 2.12 of the Shell Command Language:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html
The shell execution environment is described as:
> Variables with the export attribute, along with those explicitly exported
for the duration of the command, shall be passed to the utility environment
variables
which works together with the docs you linked for the `export` special
built-in command, that notes that the effect of `export XXX` is to mark the
variable `XXX` with the export attribute.
In section 2.5.3, shell variables:
> If a variable is initialized from the environment, it shall be marked for
export immediately; see the export special built-in.
That is the distinction of an environment variable inherited from the parent
process: it is marked for export "immediately", rather than when you use the
`export` special built-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2021313135 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROWCCACHE=OFF is for using sccache + flags: >- +-e ARROW_CCACHE=OFF Review Comment: I have confirmed in crossbow that this is now using sccache: https://github.com/ursacomputing/crossbow/actions/runs/14175037282/job/39707754711#step:6:417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
github-actions[bot] commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2766561846 Revision: ee58e3469bdb9c15283e402fd688fe67df8f2720 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c8a044df8f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c8a044df8f) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14175037282/job/39707754711)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on PR #45858: URL: https://github.com/apache/arrow/pull/45858#issuecomment-2766555763 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021236445
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
Ah, I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
WillAyd commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021057784
##
ci/scripts/cpp_build.sh:
##
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CC="${CC}"
+ if [ -n "${CC}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CC="ccache ${CC}"
+else
+ if command -v sccache; then
+CC="sccache ${CC}"
+ fi
+fi
+ fi
+
+ ORIGINAL_CXX="${CXX}"
+ if [ -n "${CXX}" ]; then
+if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+ CXX="ccache ${CXX}"
+else
+ if command -v sccache; then
+CXX="sccache ${CXX}"
+ fi
+fi
+ fi
meson setup \
Review Comment:
My knowledge of bash syntax is pretty limited, but I did start with an
export and was asked to remove in
https://github.com/apache/arrow/pull/45858#discussion_r2002481071
##
dev/tasks/tasks.yml:
##
@@ -815,7 +815,10 @@ tasks:
ci: github
template: docker-tests/github.linux.yml
params:
- flags: -e ARROW_USE_MESON=ON
+ # ARROWCCACHE=OFF is for using sccache
+ flags: >-
+-e ARROW_CCACHE=OFF
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-45853: [C++][Dev] Fix Meson compilation issues in Docker builds [arrow]
pitrou commented on code in PR #45858: URL: https://github.com/apache/arrow/pull/45858#discussion_r2021030294 ## dev/tasks/tasks.yml: ## @@ -815,7 +815,10 @@ tasks: ci: github template: docker-tests/github.linux.yml params: - flags: -e ARROW_USE_MESON=ON + # ARROWCCACHE=OFF is for using sccache + flags: >- +-e ARROW_CCACHE=OFF Review Comment: But it's spelt `ARROW_USE_CCACHE` above. Are you sure this is working as intended? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
