Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-4854877910 I think most of these occurrences have already been fixed separately but there are still a couple of them, for example in the PyArrow test suite. @WillAyd Do you want to push this through? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-4854633438 Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-3023053928 @WillAyd Apart from rebasing, it seems there are only a couple comments left to address and it should be good to go. Do you want to do that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2860397273 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2860406006 Revision: 00e3e8b8603a1f19d87e63d31cd6241af11b5de5 Submitted crossbow builds: [ursacomputing/crossbow @ actions-d0deefb6b2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d0deefb6b2) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405452/job/41830724152)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405340/job/41830723656)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405665/job/41830725637)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893406274/job/41830730894)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893406352/job/41830731230)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405960/job/41830727371)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405528/job/41830724197)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405939/job/41830727344)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405909/job/41830727050)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405897/job/41830727049)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893406415/job/41830733166)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893406053/job/41830729000)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893406110/job/41830730551)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405914/job/41830727618)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14893405690/job/41830726535)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989168/job/40962119492)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989252/job/40962119927)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989831/job/40962125361)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988850/job/40962117246)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989503/job/40962122853)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989363/job/40962122572)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988769/job/40962117158)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988719/job/40962117116)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601987958/job/40962114190)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988013/job/40962112304)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988734/job/40962117168)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601988892/job/40962117618)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989260/job/40962122353)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601987981/job/40962112670)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14601989948/job/40962127437)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054420288 ## ci/docker/python-sdist.dockerfile: ## @@ -32,5 +32,6 @@ RUN apt-get update -y -q && \ COPY python/requirements-build.txt \ /arrow/python/requirements-build.txt RUN pip3 install --requirement /arrow/python/requirements-build.txt +RUN pip3 install build Review Comment: I think we can indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054427639 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: And, actually, you might perhaps be able to remove this entire file, since all dependencies here are also listed in `pyproject.toml`. **Edit:** scratch that, the NumPy version is different in `pyproject.toml` vs. `requirements-wheel-build.txt`. Should we perhaps fix that? @jorisvandenbossche @h-vetinari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054429411 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: Another thing: the `python_version<'3.9'` part can be removed since 3.9 is the minimum supported Python version :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054428177 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: (and then the same may also apply to `requirements-build.txt`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054427639 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: And, actually, you might perhaps be able to remove this entire file, since all dependencies here are also listed in `pyproject.toml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054425585 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: Can you try to remove `wheel` below? I don't think it's gonna be necessary anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054424712 ## docs/source/developers/python.rst: ## @@ -427,8 +427,8 @@ libraries), one can set ``--bundle-arrow-cpp``: .. code-block:: $ pip install wheel # if not installed Review Comment: ```suggestion $ pip install build # install build frontend ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054424219 ## docs/source/developers/python.rst: ## @@ -427,8 +427,8 @@ libraries), one can set ``--bundle-arrow-cpp``: .. code-block:: $ pip install wheel # if not installed - $ python setup.py build_ext --build-type=$ARROW_BUILD_TYPE \ ---bundle-arrow-cpp bdist_wheel + $ python -m build --wheel --config-settings=--build-type=$ARROW_BUILD_TYPE \ +--config-settings=--bundle-arrow-cpp --no-isolation . Review Comment: Let's use the env vars in these doc snippets instead of `--config-settings`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2054421367
##
ci/scripts/python_wheel_macos_build.sh:
##
@@ -176,7 +176,7 @@ export CMAKE_PREFIX_PATH=${build_dir}/install
export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION}
pushd ${source_dir}/python
-python setup.py bdist_wheel
+python -m build --wheel --no-isolation .
Review Comment:
According to https://build.pypa.io/en/stable/index.html , it's recommended
not to pass `--wheel` so that:
> By default, a source distribution (sdist) is built from {srcdir} and a
binary distribution (wheel) is built from the sdist. This is recommended as it
will ensure the sdist can be used to build wheels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054411476 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: We can deprecate them (in a separate PR indeed) but we can't remove them immediately as it would break user builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2821660616 Revision: 65487017891d8ed6f2dcfa7e25aac7d557dc2a9b Submitted crossbow builds: [ursacomputing/crossbow @ actions-ec8ed043c1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ec8ed043c1) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296040/job/40949777279)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598297319/job/40949784342)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296692/job/40949780710)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296997/job/40949783254)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598295870/job/40949774400)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296669/job/40949780677)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296124/job/40949777965)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296322/job/40949778594)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296535/job/40949779430)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598295887/job/40949774927)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598295476/job/40949771461)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598295826/job/40949774194)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296245/job/40949777979)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296490/job/40949779473)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14598296012/job/40949776461)| |wheel-manylinux-2-28-cp311-cp311-amd64|[
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
Looks like that did the trick - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054091380 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: That works too. The documented approach for this currently uses the command line argument, but it appears that more generally in the Python documentation that env vars are the documented approach. Maybe its worth removing the CLI arguments from setuptools if the environment variable approach is the one we want to stick to (in a separate PR?) ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: That works too. The documented approach for this currently uses the command line argument, but it appears that more generally in the Python documentation that env vars are the favored approach. Maybe its worth removing the CLI arguments from setuptools if the environment variable approach is the one we want to stick to (in a separate PR?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054091380 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: That works too. The documented approach for this currently the command line argument, but it appears that more generally in the Python documentation that env vars are the documented approach. Maybe its worth removing the CLI arguments from setuptools if the environment variable approach is the one we want to stick to (in a separate PR?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054041989 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: Or simply `set PYARROW_BUNDLE_ARROW_CPP=1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2821200855 Revision: 65487017891d8ed6f2dcfa7e25aac7d557dc2a9b Submitted crossbow builds: [ursacomputing/crossbow @ actions-bf81d96de4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bf81d96de4) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594955781/job/40938539174)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594955090/job/40938538030)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594955523/job/40938538821)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594955986/job/40938539393)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594956392/job/40938540581)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14594955346/job/40938538123)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2821194347 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2054017318
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -68,11 +68,12 @@ jobs:
@rem We can remove this workaround once we find a way to use
@rem pulled caches when build an image.
echo on
- archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
-archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
No, you have to do it in this PR. This will ensure it doesn't use any
outdated cached image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2054008753
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -68,11 +68,12 @@ jobs:
@rem We can remove this workaround once we find a way to use
@rem pulled caches when build an image.
echo on
- archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
-archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
Hmm OK - so is that something we would have to do in a follow PR after this
gets merged? Or is there a way to tell it to use the docker image it builds in
the preceding CI step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2053952986 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: Yea I too find this pretty verbose. We can go back to using -C instead of --config-settings if we want that succinctness again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2053481572
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -68,11 +68,12 @@ jobs:
@rem We can remove this workaround once we find a way to use
@rem pulled caches when build an image.
echo on
- archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
-archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
I think you want to bump the image tag instead:
https://github.com/apache/arrow/blob/d2ddee62329eb711572b4d71d6380673d7f7edd1/.env#L95-L100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
pitrou commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2053477008 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: Note this ugly `--config-settings` is why it's nice to have the options configurable via environment variables as well ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2053108110
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -68,11 +68,12 @@ jobs:
@rem We can remove this workaround once we find a way to use
@rem pulled caches when build an image.
echo on
- archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
-archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
It looks like this is what "fixes" the windows crossbow jobs. I don't fully
understand what is going on here, but I came across this in the comment
directly preceding this as a solution.
It seems like the windows crossbow job had a pre-existing issue with the
sequence of building an image then executing it through archery (?). I am not
sure if this PR needs to solve this or if its just a caching thing that is
expected to go away once in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2819180674 Revision: 0651562ad2f76661a3e6bdde41a51d490cc7aad3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-12ef728873](https://github.com/ursacomputing/crossbow/branches/all?query=actions-12ef728873) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722769/job/40890507954)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722765/job/40890508018)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722635/job/40890507976)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722771/job/40890507966)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722691/job/40890508385)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14578722641/job/40890508389)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2819173535 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2816840011 Revision: 032050ca2a8bf73ac08178820bfd01e8402cb48f Submitted crossbow builds: [ursacomputing/crossbow @ actions-9054ce84ed](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9054ce84ed) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282419/job/40824889973)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282529/job/40824890209)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282421/job/40824889985)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282425/job/40824889993)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282479/job/40824890153)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14552282422/job/40824889974)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2816839334 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2810479031 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2810500576 Revision: 032050ca2a8bf73ac08178820bfd01e8402cb48f Submitted crossbow builds: [ursacomputing/crossbow @ actions-2a2ee27448](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2a2ee27448) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp310-cp310-amd64)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp311-cp311-amd64)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp312-cp312-amd64)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp313-cp313-amd64)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp313-cp313t-amd64)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-2a2ee27448-github-wheel-windows-cp39-cp39-amd64)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062:
URL: https://github.com/apache/arrow/pull/46062#issuecomment-2797211397
```
Invalid group(s) {'wheel-windows-*'}. Must be one of {'test', 'r',
'homebrew', 'cpp', 'example-cpp', 'linux-arm64', 'verify-rc-source-macos',
'nightly-packaging', 'nightly-release', 'c-glib', 'verify-rc',
'example-python', 'linux', 'ruby', 'nightly-tests', 'python', 'packaging',
'example', 'conan', 'vcpkg', 'integration', 'verify-rc-source-linux', 'fuzz',
'wheel', 'verify-rc-source', 'linux-amd64', 'nightly', 'cuda'}
The Archery job run can be found at:
https://github.com/apache/arrow/actions/runs/14406410809
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2040088106 ## python/requirements-wheel-build.txt: ## @@ -1,3 +1,4 @@ +build Review Comment: OK after some more debugging, it looks like although the docker image being built does get build installed: https://github.com/ursacomputing/crossbow/actions/runs/14406479678/job/40404156758#step:7:6775 The actual environment within which the batch script is executed still does not: https://github.com/ursacomputing/crossbow/actions/runs/14406479678/job/40404156758#step:7:10904 Without being super familiar with how archery works, is it possible that it still pulls a remote image down which does not contain `build` rather than using the image that we build as part of CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2797208262 @github-actions crossbow submit -g wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2797220054 Revision: ac586c6d5194afd0955f34977cb3e09b73c9ba4c Submitted crossbow builds: [ursacomputing/crossbow @ actions-f203770da0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f203770da0) |Task|Status| ||--| |wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406479867/job/40404157539)| |wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406479678/job/40404156758)| |wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406480454/job/40404159527)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406480053/job/40404158301)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406479711/job/40404156722)| |wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14406480415/job/40404158916)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2797214414 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2796795566 Revision: c5ebe5e7254fe2245513ecbfbb5d90bdbcd4992c Submitted crossbow builds: [ursacomputing/crossbow @ actions-7156657e3b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7156657e3b) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240717/job/40393529885)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240294/job/40393525384)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240849/job/40393530378)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403239120/job/40393517310)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240289/job/40393525529)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240660/job/40393529295)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240834/job/40393529985)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240605/job/40393528655)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403239862/job/40393520461)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403239115/job/40393516872)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240651/job/40393529460)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240472/job/40393526347)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240067/job/40393523060)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240304/job/40393525624)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14403240356/job/40393526079)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870132/job/40363299264)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870240/job/40363299522)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392869814/job/40363296342)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392869503/job/40363293946)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870468/job/40363302459)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870104/job/40363299253)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870264/job/40363299797)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870345/job/40363300305)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392869948/job/40363297753)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870018/job/40363298030)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870097/job/40363299148)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870381/job/40363300474)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870158/job/40363299423)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870291/job/40363300079)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392870630/job/40363301559)| |wheel-manylinux-2-28-cp311-cp311-amd64|[) Downloading build-1.2.2.post1-py3-none-any.whl.metadata (6.5 kB) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2787439997 :warning: GitHub issue #46061 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2791352946 Revision: d8d54e55a429209a3d0ee418cfefb5e1b6558c64 Submitted crossbow builds: [ursacomputing/crossbow @ actions-615c615d8d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-615c615d8d) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582836/job/40292779994)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582296/job/40292775539)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582642/job/40292777690)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582447/job/40292777184)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582890/job/40292781624)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582070/job/40292774921)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370583127/job/40292781822)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582813/job/40292781438)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582376/job/40292776546)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582682/job/40292778417)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370583153/job/40292781936)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582565/job/40292777392)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582359/job/40292776239)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582766/job/40292780015)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14370582183/job/40292775092)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
kou commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2036285942
##
python/requirements-wheel-build.txt:
##
@@ -1,3 +1,4 @@
+build
Review Comment:
We may need this temporary:
```diff
diff --git a/dev/tasks/python-wheels/github.windows.yml
b/dev/tasks/python-wheels/github.windows.yml
index 063ec1d632..bb9e630aa1 100644
--- a/dev/tasks/python-wheels/github.windows.yml
+++ b/dev/tasks/python-wheels/github.windows.yml
@@ -69,9 +69,9 @@ jobs:
@rem pulled caches when build an image.
echo on
archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
+ @rem if errorlevel 1 (
archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
+ @rem )
archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- uses: actions/upload-artifact@v4
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
raulcd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2788784506 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2790169806 Revision: d413d7b579b6922b2e0cd040b43489258a5e83db Submitted crossbow builds: [ursacomputing/crossbow @ actions-e538b7d250](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e538b7d250) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406974/job/40263599160)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407665/job/40263605017)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361409176/job/40263610513)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407239/job/40263601914)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406642/job/40263596506)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407994/job/40263607293)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406760/job/40263596409)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406842/job/40263598096)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406541/job/40263596216)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361408085/job/40263607410)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407140/job/40263601637)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361406801/job/40263597307)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407836/job/40263606123)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407295/job/40263603251)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14361407725/job/40263605523)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124272/job/40255718411)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124090/job/40255717371)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124507/job/40255720522)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359125710/job/40255732366)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124572/job/40255721136)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359126153/job/40255733906)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359123698/job/40255716539)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359126668/job/40255736590)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359125221/job/40255726951)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359123968/job/40255716564)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359126602/job/40255735658)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359125781/job/40255732532)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124307/job/40255718623)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359124774/job/40255722995)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359125170/job/40255726023)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14360920089/job/40261957513)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919370/job/40261951044)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360920717/job/40261962930)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360920044/job/40261956948)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919019/job/40261948304)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360918794/job/40261947004)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919952/job/40261954379)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919454/job/40261951843)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919906/job/40261954012)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360918742/job/40261946963)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919984/job/40261956201)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919201/job/40261948953)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360920015/job/40261956630)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360920562/job/40261961986)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360919399/job/40261951029)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806677/job/40258080670)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805166/job/40258065638)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805954/job/40258074144)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805164/job/40258065572)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805736/job/40258070878)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806926/job/40258081066)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805987/job/40258073329)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806104/job/40258076283)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806099/job/40258076364)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806095/job/40258076376)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805768/job/40258071906)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805697/job/40258070099)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806410/job/40258079638)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359805250/job/40258066330)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14359806039/job/40258075464)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758151/job/40261389415)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757624/job/40261385760)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757313/job/40261382613)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757897/job/40261387266)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758107/job/40261388776)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758136/job/40261389240)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758204/job/40261389961)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757368/job/40261382876)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758792/job/40261395758)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757620/job/40261385335)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757815/job/40261386487)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360758704/job/40261394824)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757445/job/40261383125)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757930/job/40261387651)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14360757570/job/40261385088)| |wheel-manylinux-2-28-cp311-cp311-amd64|[ |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653924/job/40234793473)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654120/job/40234795092)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653574/job/40234789912)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653192/job/40234787494)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653397/job/40234788427)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654929/job/40234800721)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654550/job/40234798125)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653405/job/40234788387)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653695/job/40234789959)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654076/job/40234793845)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654193/job/40234795446)| |wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352653861/job/40234791734)| |wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654584/job/40234798492)| |wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654721/job/40234798848)| |wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14352654650/job/40234798536)| |wheel-manylinux-2-28-cp311-cp311-amd64|[: ``` > raise CalledProcessError(retcode, cmd) E subprocess.CalledProcessError: Command '['/private/var/folders/k3/c71kbslj38s1vm3tnwmqyd98gn/T/arrow-HEAD.X.1a2alPCQ/miniforge/envs/conda-source/bin/python3.13', '-m', 'pip', 'install', '.']' returned non-zero exit status 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
kou commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2788069010 CI failures are unrelated to this change and we should fix it as a separated PR, right? * [Python / AMD64 macOS 13 Python 3 (pull_request)](https://github.com/apache/arrow/actions/runs/14346796214/job/40218046204?pr=46062) * [Python / ARM64 macOS 14 Python 3 (pull_request)](https://github.com/apache/arrow/actions/runs/14346796214/job/40218046511?pr=46062) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
kou commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2788069731 Related...? https://github.com/apache/arrow/actions/runs/14346796214/job/40218046511?pr=46062#step:9:2258 ```text error: invalid command 'bdist_wheel' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2034288572 ## dev/release/verify-release-candidate.bat: ## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build -C--bundle-arrow-cpp . --wheel || exit /B 1 Review Comment: Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2787965722 Revision: 4de1acfc0989d0f70149de49676db310b91395b8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-7f6485048d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7f6485048d) |Task|Status| ||--| |verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500687/job/40217230882)| |verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346499973/job/40217227526)| |verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500219/job/40217228397)| |verify-rc-source-cpp-linux-ubuntu-24.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500274/job/40217228688)| |verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500226/job/40217228393)| |verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500471/job/40217229932)| |verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500299/job/40217228827)| |verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500392/job/40217229690)| |verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500115/job/40217228065)| |verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500876/job/40217231631)| |verify-rc-source-csharp-linux-ubuntu-24.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500746/job/40217231125)| |verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500823/job/40217231549)| |verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500618/job/40217230591)| |verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14346500338/job/40217229137)| |verify-rc-source-integration-linux-conda-latest-amd64|[ instead of `-C` for
readability?
Can we use `python -m build . ${OPTIONS}` or `python -m build ${OPTIONS} .`
instead of `python -m build ${OPTIONS1} . ${OPTIONS2}` for readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
WillAyd commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2787585096 @github-actions crossbow submit -g python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46061: [Python] Replace setup.py invocations with modern commands [arrow]
github-actions[bot] commented on PR #46062: URL: https://github.com/apache/arrow/pull/46062#issuecomment-2787590729 Revision: 4de1acfc0989d0f70149de49676db310b91395b8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-963156823c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-963156823c) |Task|Status| ||--| |example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977819/job/40206599318)| |example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/14342978059/job/40206600740)| |test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/14342978090/job/40206601310)| |test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977610/job/40206598247)| |test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977823/job/40206599313)| |test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977929/job/40206600322)| |test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977951/job/40206600334)| |test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977853/job/40206599783)| |test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977635/job/40206598287)| |test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977599/job/40206598875)| |test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/14342978254/job/40206602416)| |test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977698/job/40206598585)| |test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14342978169/job/40206601779)| |test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14342978196/job/40206601993)| |test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/14342977882/job/40206599724)| |test-cond
