Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
conbench-apache-arrow[bot] commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2803655865 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 72c246ad923945ff64bd05de3e6e857f574eea20. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/40552212960) has more details. It also includes information about 78 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
assignUser merged PR #46108: URL: https://github.com/apache/arrow/pull/46108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2800781414 It worked. This is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2800354569 * [ ] debian/bookworm * [x] debian/trixie * [ ] ubuntu/jammy * [ ] ubuntu:noble * [ ] arm64v8/debian:bookworm * [ ] arm64v8/debian:trixie * [ ] arm64v8/ubuntu:jammy * [ ] arm64v8/ubuntu:noble * [ ] almalinux:9 * [ ] almalinux:8 * [ ] amazonlinux:2023 * [ ] quay.io/centos/centos:stream9 * [ ] quay.io/centos/centos:stream8 * [ ] centos:7 * [ ] arm64v8/almalinux:9 * [ ] arm64v8/almalinux:8 * [ ] arm64v8/amazonlinux:2023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108:
URL: https://github.com/apache/arrow/pull/46108#issuecomment-2800349711
> I am testing this in #46076 and getting errors because the repo files
still point to repo1.a.o but I guess that's expected because we have to
regenerate the list?
Right. We need to rebuild `apache-arrow-apt-source`/`apache-arrow-release`
packages for 20.0.0 because they include repository URLs.
I'll test the current verify scripts with 20.0.0 RC0 packages before we
merge this:
```diff
diff --git a/dev/release/verify-apt.sh b/dev/release/verify-apt.sh
index 02296c2079..90c171e906 100755
--- a/dev/release/verify-apt.sh
+++ b/dev/release/verify-apt.sh
@@ -131,7 +131,7 @@ else
rc)
sed \
-i"" \
--e "s,^URIs: \\(.*\\)/,URIs: \\1-${suffix}/,g" \
+-e "s,^URIs:
https://repo1.maven.org/maven2/org/apache/arrow/${distribution},URIs:
${artifactory_base_url}/,g" \
/etc/apt/sources.list.d/apache-arrow.sources
;;
esac
```
```diff
diff --git a/dev/release/verify-yum.sh b/dev/release/verify-yum.sh
index 8691e538ec..d1d4b25574 100755
--- a/dev/release/verify-yum.sh
+++ b/dev/release/verify-yum.sh
@@ -179,6 +179,7 @@ else
suffix=${TYPE%-release}
sed \
-i"" \
+ -e
"s,https://repo1.maven.org/maven2/org/apache/arrow,${artifactory_base_url},g"; \
-e "s,/almalinux/,/almalinux-${suffix}/,g" \
-e "s,/centos/,/centos-${suffix}/,g" \
-e "s,/amazon-linux/,/amazon-linux-${suffix}/,g" \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2800351745 > We should also revert #46082 We don't need to revert #46082 because it's only for Maven repository. This feature is needed for Artifactory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
assignUser commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2796601789 We should also revert https://github.com/apache/arrow/pull/46082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
assignUser commented on code in PR #46108:
URL: https://github.com/apache/arrow/pull/46108#discussion_r2039295806
##
dev/release/verify-yum.sh:
##
@@ -162,29 +157,33 @@ if [ "${TYPE}" = "local" ]; then
${install_command} "${release_path}"
else
package_version="${VERSION}"
+ if [ "${TYPE}" = "rc" ]; then
+suffix=${TYPE%-release}
+distribution_prefix+="-${suffix}"
+ fi
${install_command} \
${repository_base_url}/${distribution_prefix}/${repository_version}/apache-arrow-release-latest.rpm
Review Comment:
```suggestion
${artifactory_base_url}/${distribution_prefix}/${repository_version}/apache-arrow-release-latest.rpm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
assignUser commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2796548894 I am testing this in #46076 and getting errors because the repo files still point to repo1.a.o but I guess that's expected because we have to regenerate the list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
assignUser commented on code in PR #46108:
URL: https://github.com/apache/arrow/pull/46108#discussion_r2039289089
##
dev/release/verify-apt.sh:
##
@@ -66,12 +66,11 @@ ${APT_INSTALL} \
code_name="$(lsb_release --codename --short)"
distribution="$(lsb_release --id --short | tr 'A-Z' 'a-z')"
-production_repository_base_url="https://repo1.maven.org/maven2/org/apache/arrow/${distribution}";
-staging_repository_base_url="https://repository.apache.org/content/repositories/staging/org/apache/arrow/${distribution}";
-repository_base_url="${production_repository_base_url}"
+artifactory_base_url="https://packages.apache.org/artifactory/arrow/${distribution}";
if [ "${TYPE}" = "rc" ]; then
- repository_base_url="${staging_repository_base_url}"
-fi
+ suffix=${TYPE%-release}
+ artifactory_base_url+="-${suffix}"
+esac
Review Comment:
```suggestion
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2796133270 Uploaded to https://packages.apache.org/ui/native/arrow/*-rc/ . I'll check them later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
kou commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2796122331 I'm trying this with 20.0.0 RC0 artifacts on local... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46083: [Release][Packages] Use Artifactory for APT/Yum repositories again [arrow]
github-actions[bot] commented on PR #46108: URL: https://github.com/apache/arrow/pull/46108#issuecomment-2796103457 :warning: GitHub issue #46083 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
