Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2816227389 > There were no benchmark performance regressions. 🎉 I was a little worried this casting was going to hit us, but it looks like no! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
conbench-apache-arrow[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2816058831 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c54b039c77dd0bfa822bc0a54c7f4ca1189e0d57. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/40797519181) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2813935518 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049590299 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: > With the two concerns above, I wonder if we have a reproducible case for us to validate our fix? I assume you're looking for something more than the sanitizer test that is implemented here? I will admit I'm not super familiar with this area of the code so have been leaning on the sanitizer failing/passing to tell me if things are ok (+ passing tests for behavior) but we might be missing coverage. I'm happy to try other changes if you have any that I should. Or maybe we make a follow on to investigate why this fix is needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
assignUser commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2815366217 @jonkeane No problem, we need to do another RC anyway :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2050552290 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,7 +276,8 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); Review Comment: Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2815355054 @assignUser any chance we could get this pulled into the 20 release branch? We still have enough runway with CRAN (5/10 is our deadline) that we might not need to do a special R-only release just for this if we do. Or at least, I think it's ok for us to wait and see if 20 makes it out before then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane merged PR #46124: URL: https://github.com/apache/arrow/pull/46124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049948899 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,7 +276,8 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); Review Comment: As explained in https://github.com/apache/arrow/pull/46124#issuecomment-2814416656 , it could be confusing to people why this casting is ever needed, given that it is eventually passed down into `std::memcpy` as a `void *`. We can use a comment. ```suggestion // NOTE: UBSAN may falsely report "misaligned load" in `std::memcpy` on some // platforms when using 64-bit pointers. Cast to an 8-bit pointer to work around // this. const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2814416656 OK, I did some [experiments](https://godbolt.org/z/vhcGY3xhd) that can further justify this fix. This experiment proves that merely changing the pointer type passed into `std::memcpy` will affect how the compiler generates UB detection stub code which reports arguably false alarm (otherwise we can't explain why changing the pointer type from `uint64_t *` to `uint8_t *` (and passing into `std::memcpy` as `void *`) eliminates the sanitizer error). For function (64-bit pointer) ``` int64_t read_mc64(const uint64_t* src, size_t n) { uint64_t result = 0; std::memcpy(&result, src, n); return result; } ``` The compiler generates an alignment checking stub: ``` tst x0, #0x7 b.ne.LBB2_4 ``` If the check failed (unaligned to 8-byte), it invokes UBSAN reporting routine `__ubsan_handle_type_mismatch_v1` regardless of how it is used (in this function, passed into `std::memcpy` as a `void *`, which IMO is NOT UB). Whereas for function (8-bit pointer) ``` uint64_t read_mc8(const uint8_t* src, size_t n) { uint64_t result = 0; std::memcpy(&result, src, n); return result; } ``` No alignment checking stub so everything is fine. Hope this could help people to understand better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2814172114 Revision: 07d758253c472f5b6d080a41b01bb7576296dc8e Submitted crossbow builds: [ursacomputing/crossbow @ actions-bccc2b44c0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bccc2b44c0) |Task|Status| ||--| |r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258750/job/40758284803)| |r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258331/job/40758282039)| |test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258323/job/40758281633)| |test-r-clang-asan|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258612/job/40758283601)| |test-r-clang-ubsan|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258689/job/40758284626)| |test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/40758283640)| |test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258425/job/40758282400)| |test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258804/job/40758284763)| |test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258434/job/40758283250)| |test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258456/job/40758282649)| |test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258587/job/40758283501)| |test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258399/job/40758282082)| |test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258408/job/40758283221)| |test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258475/job/40758283476)| |test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258332/job/40758283751)| |test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258476/job/40758282693)| |test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14526258660/job/40758284149)| |test-r-linux-valgrind|[; uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: Oh, exactly! We do have one! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049633851 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: Ah! Here is a link to that same failing build: https://github.com/ursacomputing/crossbow/actions/runs/14459183248/job/40548479728#step:7:5379 The test that triggers that is https://github.com/apache/arrow/blob/cc56a5e78eeede2715f12b6ca61ebea741f38f60/r/tests/testthat/test-dataset-dplyr.R#L183-L196 so that _should_ trigger it for you if that's helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049626926 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: > I assume you're looking for something more than the sanitizer test that is implemented here? I will admit I'm not super familiar with this area of the code so have been leaning on the sanitizer failing/passing to tell me if things are ok (+ passing tests for behavior) but we might be missing coverage. Oh sorry, I'm only looking for something that 1) fails the sanitizer w/o your change and 2) passes the sanitizer with your change. Seems you already have one? If so that should suffice. Actually the sanitizer can be mysterious to me too, so I was trying to make sense of why it complains and how this change calms it. But if we had this reproducible test that assures that the fix actually works in practice, I'm happy to let it in even though I'm not able to make perfect sense of how if works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2813939255 Revision: 07d758253c472f5b6d080a41b01bb7576296dc8e Submitted crossbow builds: [ursacomputing/crossbow @ actions-798e0f8cd9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-798e0f8cd9) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14524105553/job/40751690350)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049525910 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: Yeah, so to summarize, I have three concerns: 1. Why does the sanitizer complain about a line that seems to be totally innocent? (I currently assume it's because the compiler optimization/reordering.) 2. It's still not totally clear to me where these misaligned loads are originated. For instance, `memcpy` is supposed to be alignment-safe thus should not cause any alignment violation even under a sanitizer. Well by looking at the code more, I'm suspecting the warning in `compare_internal.cc:284:30` is caused by https://github.com/apache/arrow/blob/cc56a5e78eeede2715f12b6ca61ebea741f38f60/cpp/src/arrow/compute/row/compare_internal.cc#L280C16-L280C25 (compiler reordering counted, of course). But still no clue on the warning in `light_array_internal.cc:618:25`. 3. With the two concerns above, I wonder if we have a reproducible case for us to validate our fix? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2049525910 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: Yeah, so to summarize, I have three concerns: 1. Why does the sanitizer complain about a line that seems to be totally innocent? (I currently assume it's because the compiler optimization/reordering.) 2. It's still not totally clear to me where these misaligned loads are originated. For instance, `memcpy` is supposed alignment-safe thus should not cause any alignment violation even under a sanitizer. Well by looking at the code more, I'm suspecting the warning in `compare_internal.cc:284:30` is caused by https://github.com/apache/arrow/blob/cc56a5e78eeede2715f12b6ca61ebea741f38f60/cpp/src/arrow/compute/row/compare_internal.cc#L280C16-L280C25 (compiler reordering counted, of course). But still no clue on the warning in `light_array_internal.cc:618:25`. 3. Withe the two concerns above, I wonder if we have a reproducible case for us to validate our fix? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2048857300 ## cpp/src/arrow/compute/light_array_internal.cc: ## @@ -615,7 +615,9 @@ Status ExecBatchBuilder::AppendSelected(const std::shared_ptr& source target->mutable_data(2) + offsets[num_rows_before + num_rows_to_process + i]); const uint64_t* src = reinterpret_cast(ptr); -memcpy(dst, src, num_bytes); +uint8_t* dst_bytes = reinterpret_cast(dst); +const uint8_t* src_bytes = reinterpret_cast(src); +memcpy(dst_bytes, src_bytes, num_bytes); Review Comment: Thanks! Yup, this works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2048861485 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: > How does this LOC issue a misaligned load? Compiler reordering? I assume the actual code in question is the std::memcpy above right? Ah yes, you're right I've reverted the change on line 284/285 — it's not needed to resolve this sanitizer issue. > I'm also curious about that, if the problem is in std::memcpy, then why does the pointer type (uint64_t * vs uint8_t *) matter given that std::memcpy accepts void *. I was seeing complaints about misalingnment: ``` /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/row/compare_internal.cc:279:30: runtime error: load of misaligned address 0x000134060481 for type 'const uint64_t *' (aka 'const unsigned long long *'), which requires 8 byte alignment 0x000134060481: note: pointer points here 00 00 00 6a 69 68 67 66 65 64 00 00 00 00 00 00 00 00 00 04 00 00 00 05 00 00 00 06 00 00 00 07 ^ #0 0x000120826784 in void arrow::compute::KeyCompare::CompareVarBinaryColumnToRowHelper(unsigned int, unsigned int, unsigned int, unsigned short const*, unsigned int const*, arrow::compute::LightContext*, arrow::compute::KeyColumnArray const&, arrow::compute::RowTableImpl const&, unsigned char*)+0xa44 (arrow.so:arm64+0x55e6784) #1 0x0001208179c0 in arrow::compute::KeyCompare::CompareColumnsToRows(unsigned int, unsigned short const*, unsigned int const*, arrow::compute::LightContext*, unsigned int*, unsigned short*, std::__1::vector> const&, arrow::compute::RowTableImpl const&, bool, unsigned char*)+0x780 (arrow.so:arm64+0x55d79c0) #2 0x000120846c0c in std::__1::__function::__func> const&, arrow::compute::ExecContext*)::'lambda'(int, unsigned short const*, unsigned int const*, unsigned int*, unsigned short*, void*), std::__1::allocator> const&, arrow::compute::ExecContext*)::'lambda'(int, unsigned short const*, unsigned int const*, unsigned int*, unsigned short*, void*)>, void (int, unsigned short const*, unsigned int const*, unsigned int*, unsigned short*, void*)>::operator()(int&&, unsigned short const*&&, unsigned int const*&&, unsigned int*&&, unsigned short*&&, void*&&)+0x1cc (arrow.so:arm64+0x5606c0c) #3 0x0001207c79fc in arrow::compute::SwissTable::run_comparisons(int, unsigned short const*, unsigned char const*, unsigned int const*, int*, unsigned short*, std::__1::function const&, void*) const+0x2bc (arrow.so:arm64+0x55879fc) #4 0x0001207c8014 in arrow::compute::SwissTable::find(int, unsigned int const*, unsigned char*, unsigned char const*, unsigned int*, arrow::util::TempVectorStack*, std::__1::function const&, void*) const+0x294 (arrow.so:arm64+0x5588014) #5 0x000120843110 in arrow::compute::(anonymous namespace)::GrouperFastImpl::ConsumeImpl(arrow::compute::ExecSpan const&, arrow::compute::(anonymous namespace)::GrouperMode)+0x1d10 (arrow.so:arm64+0x5603110) #6 0x000120840548 in arrow::compute::(anonymous namespace)::GrouperFastImpl::ConsumeImpl(arrow::compute::ExecSpan const&, long long, long long, arrow::compute::(anonymous namespace)::GrouperMode)+0x548 (arrow.so:arm64+0x5600548) #7 0x00011c7f4b90 in arrow::acero::aggregate::GroupByNode::Merge()+0x4d0 (arrow.so:arm64+0x15b4b90) #8 0x00011c7f8188 in arrow::acero::aggregate::GroupByNode::OutputResult(bool)+0x4c8 (arrow.so:arm64+0x15b8188) #9 0x00011c7f99cc in arrow::acero::aggregate::GroupByNode::InputReceived(arrow::acero::ExecNode*, arrow::compute::ExecBatch)+0xa8c (arrow.so:arm64+0x15b99cc) #10 0x00011ca36488 in arrow::acero::MapNode::InputReceived(arrow::acero::ExecNode*, arrow::compute::ExecBatch)+0x348 (arrow.so:arm64+0x17f6488) #11 0x00011ca36488 in arrow::acero::MapNode::InputReceived(arrow::acero::ExecNode*, arrow::compute::ExecBatch)+0x348 (arrow.so:arm64+0x17f6488) #12 0x00011cac78b8 in std::__1::__function::__func, arrow::Status ()>::operator()()+0xa78 (arrow.so:arm64+0x18878b8) #13 0x00011ca62db0 in std::__1::__bind_return, std::__1::function>, std::__1::tuple<>, __is_valid_bind_return, std::__1::function>, std::__1::tuple<>>::value>::type std::__1::__bind&, std::__1::function>::operator()
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045208022 ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: From the error message in the issue: ``` /Users/ripley/R/packages/tests-SAN/arrow/tools/cpp/src/arrow/compute/row/compare_internal.cc:284:30: runtime error: load of misaligned address 0x000150040c01 for type 'const uint64_t *' (aka 'const unsigned long long *'), which requires 8 byte alignment ``` How does this LOC issue a misaligned load? Compiler reordering? I assume the actual code in question is the `std::memcpy` above right? ## cpp/src/arrow/compute/row/compare_internal.cc: ## @@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper( int32_t tail_length = length - j * 8; uint64_t tail_mask = ~0ULL >> (64 - 8 * tail_length); uint64_t key_left = 0; - std::memcpy(&key_left, key_left_ptr + j, tail_length); + const uint8_t* src_bytes = reinterpret_cast(key_left_ptr + j); + std::memcpy(&key_left, src_bytes, tail_length); uint64_t key_right = key_right_ptr[j]; result_or |= tail_mask & (key_left ^ key_right); } int result = result_or == 0 ? 0xff : 0; -result *= (length_left == length_right ? 1 : 0); Review Comment: I'm also curious about that, if the problem is in `std::memcpy`, then why does the pointer type (`uint64_t *` vs `uint8_t *`) matter given that `std::memcpy` accepts `void *`. ## cpp/src/arrow/compute/light_array_internal.cc: ## @@ -615,7 +615,9 @@ Status ExecBatchBuilder::AppendSelected(const std::shared_ptr& source target->mutable_data(2) + offsets[num_rows_before + num_rows_to_process + i]); const uint64_t* src = reinterpret_cast(ptr); -memcpy(dst, src, num_bytes); +uint8_t* dst_bytes = reinterpret_cast(dst); +const uint8_t* src_bytes = reinterpret_cast(src); +memcpy(dst_bytes, src_bytes, num_bytes); Review Comment: I think we can instead use `dst` w/o `reinterprete_cast`ing to `uint64_t*` and `ptr` (as source): ``` auto dst = target->mutable_data(2) + offsets[num_rows_before + num_rows_to_process + i]; memcpy(dst, ptr, num_bytes); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045192318 ## dev/tasks/tasks.yml: ## @@ -1087,13 +1087,25 @@ tasks: image: ubuntu-r-sanitizer timeout: 120 - test-r-clang-sanitizer: + test-r-clang-asan: ci: github template: docker-tests/github.linux.yml params: env: R_PRUNE_DEPS: TRUE - image: r-clang-sanitizer + image: r-clang-asan + + test-r-clang-ubsan: +ci: github +template: docker-tests/github.linux.yml +params: + env: +R_PRUNE_DEPS: TRUE + image: r-clang-ubsan + + test-r-m1-san: +ci: github +template: r/github.macos.m1san.yml Review Comment: Yeah, interesting. I wonder if pulling before the fix from that PR with the new CI job would catch that (probably easier to do after this PR is merged since it would mean grabbing just a single commit...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045188499 ## dev/tasks/tasks.yml: ## @@ -1087,13 +1087,25 @@ tasks: image: ubuntu-r-sanitizer timeout: 120 - test-r-clang-sanitizer: + test-r-clang-asan: ci: github template: docker-tests/github.linux.yml params: env: R_PRUNE_DEPS: TRUE - image: r-clang-sanitizer + image: r-clang-asan + + test-r-clang-ubsan: +ci: github +template: docker-tests/github.linux.yml +params: + env: +R_PRUNE_DEPS: TRUE + image: r-clang-ubsan + + test-r-m1-san: +ci: github +template: r/github.macos.m1san.yml Review Comment: Interesting. I've encountered a similar situation where my local mac sanitizer does flag a [data race](https://github.com/apache/arrow/issues/45788) meanwhile our CI sanitizer is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
zanmato1984 commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045188499 ## dev/tasks/tasks.yml: ## @@ -1087,13 +1087,25 @@ tasks: image: ubuntu-r-sanitizer timeout: 120 - test-r-clang-sanitizer: + test-r-clang-asan: ci: github template: docker-tests/github.linux.yml params: env: R_PRUNE_DEPS: TRUE - image: r-clang-sanitizer + image: r-clang-asan + + test-r-clang-ubsan: +ci: github +template: docker-tests/github.linux.yml +params: + env: +R_PRUNE_DEPS: TRUE + image: r-clang-ubsan + + test-r-m1-san: +ci: github +template: r/github.macos.m1san.yml Review Comment: Interesting. I've encountered a similar situation where my local mac sanitizer does flags a [data race](https://github.com/apache/arrow/issues/45788) meanwhile our CI sanitizer is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803480854 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
amoeba commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045098899 ## docker-compose.yml: ## @@ -1745,6 +1746,34 @@ services: /bin/bash -c " /arrow/ci/scripts/r_sanitize.sh /arrow" + r-clang-ubsan: +image: ${REPO}:r-rhub-clang-ubsan-devel-latest +build: + context: . + dockerfile: ci/docker/linux-r.dockerfile + cache_from: +- ${REPO}:r-rhub-clang-ubsan-devel-latest + args: +base: rhub/clang-ubsan +cmake: ${CMAKE} +r_dev: ${ARROW_R_DEV} +r_bin: R +tz: ${TZ} +r_prune_deps: ${R_PRUNE_DEPS} +shm_size: *shm-size +environment: + <<: *common + LIBARROW_DOWNLOAD: "false" + ARROW_SOURCE_HOME: "/arrow" + ARROW_R_DEV: ${ARROW_R_DEV} + # To test for CRAN release, delete ^^ these two env vars so we download the Apache release Review Comment: Works for me, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044389136 ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . Review Comment: This is more like what CRAN runs anyway, so I updated while I was in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2045083661 ## docker-compose.yml: ## @@ -1745,6 +1746,34 @@ services: /bin/bash -c " /arrow/ci/scripts/r_sanitize.sh /arrow" + r-clang-ubsan: +image: ${REPO}:r-rhub-clang-ubsan-devel-latest +build: + context: . + dockerfile: ci/docker/linux-r.dockerfile + cache_from: +- ${REPO}:r-rhub-clang-ubsan-devel-latest + args: +base: rhub/clang-ubsan +cmake: ${CMAKE} +r_dev: ${ARROW_R_DEV} +r_bin: R +tz: ${TZ} +r_prune_deps: ${R_PRUNE_DEPS} +shm_size: *shm-size +environment: + <<: *common + LIBARROW_DOWNLOAD: "false" + ARROW_SOURCE_HOME: "/arrow" + ARROW_R_DEV: ${ARROW_R_DEV} + # To test for CRAN release, delete ^^ these two env vars so we download the Apache release Review Comment: FWIW, I don't think we ever (need) to do this. IMHO I would say let's remove this + the other sanitizer copy/pasta version of this and we can leave it up top where it is under the one R docker file. It was introduced with https://github.com/apache/arrow/pull/6995 and I don't think we've every really messed with it since. It's good to have an idea of what one might do to actually run the full real version, but we test it in other ways in our CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-280309 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800166287 Revision: d33a710ba2d6d96ebb1cda6e2596b1d3380872d2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-42aba23e69](https://github.com/ursacomputing/crossbow/branches/all?query=actions-42aba23e69) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14434143647/job/40472538956)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803638776 Revision: e1d844f5d4a62417d69b20d7258720da1535cf89 Submitted crossbow builds: [ursacomputing/crossbow @ actions-ac9b480ec4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ac9b480ec4) |Task|Status| ||--| |test-r-clang-asan|[](https://github.com/ursacomputing/crossbow/actions/runs/14460391077/job/40551807401)| |test-r-clang-ubsan|[](https://github.com/ursacomputing/crossbow/actions/runs/14460390947/job/40551807279)| |test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14460391000/job/40551807280)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803099487 Revision: 98c63b381ddc26a4ad0a4f317f5e7b2d2b42837d Submitted crossbow builds: [ursacomputing/crossbow @ actions-c47ffba7ee](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c47ffba7ee) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14456382404/job/40540438536)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803684505 @github-actions crossbow submit test-r-m1-san This is the m1-san job after the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
amoeba commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044978743 ## docker-compose.yml: ## @@ -1745,6 +1746,34 @@ services: /bin/bash -c " /arrow/ci/scripts/r_sanitize.sh /arrow" + r-clang-ubsan: +image: ${REPO}:r-rhub-clang-ubsan-devel-latest +build: + context: . + dockerfile: ci/docker/linux-r.dockerfile + cache_from: +- ${REPO}:r-rhub-clang-ubsan-devel-latest + args: +base: rhub/clang-ubsan +cmake: ${CMAKE} +r_dev: ${ARROW_R_DEV} +r_bin: R +tz: ${TZ} +r_prune_deps: ${R_PRUNE_DEPS} +shm_size: *shm-size +environment: + <<: *common + LIBARROW_DOWNLOAD: "false" + ARROW_SOURCE_HOME: "/arrow" + ARROW_R_DEV: ${ARROW_R_DEV} + # To test for CRAN release, delete ^^ these two env vars so we download the Apache release Review Comment: Hrm, I'm worried about forgetting to do this step. Is there maybe a more foolproof way to do what we want here? ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . # But unset the env var so that it doesn't cause us to run extra dev tests unset ARROW_R_DEV # Set the testthat output to be verbose for easier debugging export ARROW_R_VERBOSE_TEST=TRUE +export _R_CHECK_FORCE_SUGGESTS_=FALSE Review Comment: Worth putting your text here in the file as a comment for safe keeping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2804867578 Sorry for all of the noise here, but this is ready fro a review. https://github.com/apache/arrow/pull/46124#issuecomment-2803679856 is the run with the new CI job which fails. Then I added the fix and https://github.com/apache/arrow/pull/46124#issuecomment-2803688001 is after the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044397729 ## dev/tasks/tasks.yml: ## @@ -1087,13 +1087,25 @@ tasks: image: ubuntu-r-sanitizer timeout: 120 - test-r-clang-sanitizer: + test-r-clang-asan: ci: github template: docker-tests/github.linux.yml params: env: R_PRUNE_DEPS: TRUE - image: r-clang-sanitizer + image: r-clang-asan + + test-r-clang-ubsan: +ci: github +template: docker-tests/github.linux.yml +params: + env: +R_PRUNE_DEPS: TRUE + image: r-clang-ubsan + + test-r-m1-san: +ci: github +template: r/github.macos.m1san.yml Review Comment: ... *and* the macos-based sanitizer job that actually caught this (the linux-based on is and has been clean — I even tried in this thread to see if it's because we were skipping the tests that had issues there and nope, that santizer doesn't complain about this issue!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044396144 ## dev/tasks/tasks.yml: ## @@ -1087,13 +1087,25 @@ tasks: image: ubuntu-r-sanitizer timeout: 120 - test-r-clang-sanitizer: + test-r-clang-asan: ci: github template: docker-tests/github.linux.yml params: env: R_PRUNE_DEPS: TRUE - image: r-clang-sanitizer + image: r-clang-asan + + test-r-clang-ubsan: +ci: github +template: docker-tests/github.linux.yml +params: + env: +R_PRUNE_DEPS: TRUE + image: r-clang-ubsan Review Comment: It turns out we were _only_ running the address sanitizer here. So I've added undefined behavior sanitizer too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044394676 ## dev/tasks/docker-tests/github.linux.yml: ## @@ -66,7 +66,11 @@ jobs: uses: actions/upload-artifact@v4 with: name: test-output - path: arrow/r/check/arrow.Rcheck/tests/testthat.Rout* + path: | +arrow/r/tests/ +arrow/r/arrow.Rcheck/ +!arrow/r/arrow.Rcheck/00_pkg_src/ +!arrow/r/arrow.Rcheck/arrow/ Review Comment: The path was a typo IIUC (it didn't ever seem to upload anything), but uploading the whole .Rcheck (minus the source + libs) isn't large (a few hundred KB) and is helpful for debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044393299 ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . # But unset the env var so that it doesn't cause us to run extra dev tests unset ARROW_R_DEV # Set the testthat output to be verbose for easier debugging export ARROW_R_VERBOSE_TEST=TRUE +export _R_CHECK_FORCE_SUGGESTS_=FALSE -export UBSAN_OPTIONS="print_stacktrace=1,suppressions=/arrow/r/tools/ubsan.supp" +export SUPPRESSION_FILE=$(readlink -f "tools/ubsan.supp") +export UBSAN_OPTIONS="print_stacktrace=1,suppressions=${SUPPRESSION_FILE}" # From the old rhub image https://github.com/r-hub/rhub-linux-builders/blob/master/fedora-clang-devel-san/Dockerfile export ASAN_OPTIONS="alloc_dealloc_mismatch=0:detect_leaks=0:detect_odr_violation=0" -# run tests -pushd tests -${R_BIN} --no-save < testthat.R > testthat.out 2>&1 || { cat testthat.out; exit 1; } +${R_BIN} CMD check --no-manual --no-vignettes --no-build-vignettes arrow*.tar.gz -cat testthat.out -if grep -q "runtime error" testthat.out; then +# Find sanitizer issues, print the file(s) they are part of, and fail the job +find . -type f -name "*Rout" -exec grep -l "runtime error\|SUMMARY: UndefinedBehaviorSanitizer" {} \; > sanitizer_errors.txt +if [ -s sanitizer_errors.txt ]; then + echo "Sanitizer errors found in the following files:" + cat sanitizer_errors.txt + + # Print the content of files with errors for debugging + while read -r file; do +echo "=== $file ===" +cat "$file" +echo "=" + done < sanitizer_errors.txt + exit 1 fi Review Comment: More robust + clearer when things go wrong IMHO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044392148 ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . # But unset the env var so that it doesn't cause us to run extra dev tests unset ARROW_R_DEV # Set the testthat output to be verbose for easier debugging export ARROW_R_VERBOSE_TEST=TRUE +export _R_CHECK_FORCE_SUGGESTS_=FALSE Review Comment: Since we are using check, but we also are pruning dependencies like duckdb, we need this. We could also _not_ prune dependencies which would be how CRAN runs these, but we've never have sanitizer issues on our pruned dependency tests (most of which skip on cran too) so I'm not super worried. It would be easy to add them later. ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . Review Comment: This is more like what CRAN runs anyway, so I updated while I was in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2044392780 ## ci/scripts/r_sanitize.sh: ## @@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())') echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site # build first so that any stray compiled files in r/src are ignored -${R_BIN} CMD build . -${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz +${R_BIN} CMD build --no-build-vignettes --no-manual . # But unset the env var so that it doesn't cause us to run extra dev tests unset ARROW_R_DEV # Set the testthat output to be verbose for easier debugging export ARROW_R_VERBOSE_TEST=TRUE +export _R_CHECK_FORCE_SUGGESTS_=FALSE -export UBSAN_OPTIONS="print_stacktrace=1,suppressions=/arrow/r/tools/ubsan.supp" +export SUPPRESSION_FILE=$(readlink -f "tools/ubsan.supp") +export UBSAN_OPTIONS="print_stacktrace=1,suppressions=${SUPPRESSION_FILE}" # From the old rhub image https://github.com/r-hub/rhub-linux-builders/blob/master/fedora-clang-devel-san/Dockerfile export ASAN_OPTIONS="alloc_dealloc_mismatch=0:detect_leaks=0:detect_odr_violation=0" -# run tests -pushd tests -${R_BIN} --no-save < testthat.R > testthat.out 2>&1 || { cat testthat.out; exit 1; } +${R_BIN} CMD check --no-manual --no-vignettes --no-build-vignettes arrow*.tar.gz Review Comment: This is more like what CRAN runs anyway, so I updated while I was in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803084352 Revision: c6d228c963559baf8b5e3faddc4fec0bccc3c83c Submitted crossbow builds: [ursacomputing/crossbow @ actions-18cfaac175](https://github.com/ursacomputing/crossbow/branches/all?query=actions-18cfaac175) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14456258892/job/40540052596)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803688001 Revision: 150577dbb9e738de7e0e676240d44f58376686ca Submitted crossbow builds: [ursacomputing/crossbow @ actions-fa752e32da](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fa752e32da) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14460702642/job/40552682320)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803625906 @github-actions crossbow submit test-r-linux-sanitizer test-r-clang-asan test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2801561955 Revision: a646c49fa78b7e05f9a0aa16389ca800d0d86103 Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e718f7490](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e718f7490) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14445683709/job/40505638881)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2801888916 Revision: 5b82560c48ea5e194c1c1cf52ddc55cf4e28db6d Submitted crossbow builds: [ursacomputing/crossbow @ actions-ab0df5314a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ab0df5314a) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14448099592/job/40513631106)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803628457 Revision: 8a7896a9660cf0de0b293aadab9f7376e782dae8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-f902d3793d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f902d3793d) |Task|Status| ||--| |test-r-clang-asan|[](https://github.com/ursacomputing/crossbow/actions/runs/14460288922/job/40551517758)| |test-r-clang-ubsan|[](https://github.com/ursacomputing/crossbow/actions/runs/14460288813/job/40551517570)| |test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14460288997/job/40551518080)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803676624 @github-actions crossbow submit test-r-m1-san This is the m1-san job before the fix, it should fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803679856 Revision: 17313a502cffd58fa28dc393110a31279686226a Submitted crossbow builds: [ursacomputing/crossbow @ actions-d936b59104](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d936b59104) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14460626580/job/40552479552)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803636212 @github-actions crossbow submit test-r-linux-sanitizer test-r-clang-asan test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803589117 Revision: e4fc52a542bb2744477407f2ffb05035010c0301 Submitted crossbow builds: [ursacomputing/crossbow @ actions-8c2651c18b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8c2651c18b) |Task|Status| ||--| |test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14459985243/job/40550680963)| |test-r-clang-ubsan|[](https://github.com/ursacomputing/crossbow/actions/runs/14459985540/job/40550681754)| |test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14459985272/job/40550681031)| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14459985077/job/40550680786)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803586383 @github-actions crossbow submit test-r-m1-san test-r-linux-sanitizer test-r-clang-sanitizer test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803078100 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803483555 Revision: 1d0cbef91e10b73eb1b4ee4bc98b1b5eb2b97799 Submitted crossbow builds: [ursacomputing/crossbow @ actions-5b5998db39](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5b5998db39) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14459183248/job/40548479728)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802479043 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803106487 Revision: a60744b7fc4bc8d5d5257404b1bb04f38dd79e14 Submitted crossbow builds: [ursacomputing/crossbow @ actions-67da95c81e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-67da95c81e) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14456440033/job/40540621130)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2803102289 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802485586 Revision: d0b1dc5ecb82ad8fb3b7523107ec76b1aac643ca Submitted crossbow builds: [ursacomputing/crossbow @ actions-9e20ae5f7b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9e20ae5f7b) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14452545818/job/40528419790)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802603378 Revision: 6a09599ed2ddf0c6ab4a291d3070e9d2eb39edf9 Submitted crossbow builds: [ursacomputing/crossbow @ actions-15b7022691](https://github.com/ursacomputing/crossbow/branches/all?query=actions-15b7022691) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14453113773/job/40530201978)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802721682 Revision: b995f377fcb871631ea4dd4d4cf53899dcdc2100 Submitted crossbow builds: [ursacomputing/crossbow @ actions-a1fb3f5abd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a1fb3f5abd) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14453650637/job/40531883457)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802710311 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802651254 Revision: d1e281a713652303c6f79efe9ab53c345ad05b6d Submitted crossbow builds: [ursacomputing/crossbow @ actions-cc2204f23b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cc2204f23b) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14453351354/job/40530926477)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802645228 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802598120 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802585682 Revision: d766652351d7624b37481c246a05503179600236 Submitted crossbow builds: [ursacomputing/crossbow @ actions-89a8478faf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-89a8478faf) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14453010645/job/40529873129)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802573579 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802541725 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802559734 Revision: 0f9cb145bf88cad45b820ecaeb9766657320b9f8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-72ccc61268](https://github.com/ursacomputing/crossbow/branches/all?query=actions-72ccc61268) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14452839569/job/40529347812)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802554439 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802547206 Revision: b7cc2055ffb61fc2b7b980a5eaeab47ad3d928c1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3e6dfe7903](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3e6dfe7903) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14452745630/job/40529053660)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802068908 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2802075714 Revision: 1a4f1970ee2f465af5c0f7af87bc72460c4cc3d5 Submitted crossbow builds: [ursacomputing/crossbow @ actions-bc9f31e23a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bc9f31e23a) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14449415248/job/40518092355)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2801555945 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2801881409 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800258547 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800431632 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800433954 Revision: a646c49fa78b7e05f9a0aa16389ca800d0d86103 Submitted crossbow builds: [ursacomputing/crossbow @ actions-d0f9a8d3fc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d0f9a8d3fc) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14437350868/job/40480647321)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800367709 Revision: 19aa25c50960f436cc308451f8c35fb95d91167b Submitted crossbow builds: [ursacomputing/crossbow @ actions-e77222e057](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e77222e057) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14436636470/job/40478740880)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800380375 Revision: e7e43ba95df504f59514dbb4a638dbd578154040 Submitted crossbow builds: [ursacomputing/crossbow @ actions-0738ab34fe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0738ab34fe) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14436784221/job/40479153882)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800378356 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800365701 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800305939 Revision: 1ccb93191594b71517bd4bb15c294bfec7ae2e1a Submitted crossbow builds: [ursacomputing/crossbow @ actions-e7fca2d33e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e7fca2d33e) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14436007561/job/40477112959)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800303828 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
kou commented on code in PR #46124: URL: https://github.com/apache/arrow/pull/46124#discussion_r2041287224 ## r/tests/testthat/helper-skip.R: ## @@ -97,6 +97,7 @@ skip_on_linux_devel <- function() { # Skip when the OS is linux + and the R version is development # helpful for skipping on Valgrind, and the sanitizer checks (clang + gcc) on cran if (on_linux_dev()) { +return() skip_on_cran() Review Comment: Oh, sorry! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800260456 Revision: befd7eb4e9025b7d825eff0f813a8c8a15e33772 Submitted crossbow builds: [ursacomputing/crossbow @ actions-371845bea4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-371845bea4) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14435505465/job/40475838142)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800165477 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800150165 Revision: dcbf747444b8d754ed7e9769c47d5321e45957c1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-d58e61b81c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d58e61b81c) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14433842627/job/40471893775)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800149312 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800141242 Revision: d6093fc78b8730375d78e519d5b16bfb19e5b57b Submitted crossbow builds: [ursacomputing/crossbow @ actions-075d7a30c5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-075d7a30c5) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14433679529/job/40471528993)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800140534 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800138833 Revision: 9a12aa0668ca9854e0f3ac9b058fbb73692517a2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-27e11fa4de](https://github.com/ursacomputing/crossbow/branches/all?query=actions-27e11fa4de) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14433630749/job/40471425291)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800138100 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800022879 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800088520 Revision: 4e1cbfe8890859cadbee905f1995b1eef4e9d5b7 Submitted crossbow builds: [ursacomputing/crossbow @ actions-241b88850f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-241b88850f) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14432615607/job/40469203126)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800087649 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800078812 Revision: fd3d33dcaa6f534d2a901356e66428e58c17ae79 Submitted crossbow builds: [ursacomputing/crossbow @ actions-35a5a26f9d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-35a5a26f9d) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14432406786/job/40468764352)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800078073 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800068896 Revision: e1186854cc02f546b23a5df259672cc09d304eba Submitted crossbow builds: [ursacomputing/crossbow @ actions-7a65d04133](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7a65d04133) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14432216082/job/40468351143)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800068085 @github-actions crossbow submit test-r-m1-san -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2800025959 Revision: e4f24f84d2e7406f1a7bc0be7b6259a4a9ef8512 Submitted crossbow builds: [ursacomputing/crossbow @ actions-577d37aa51](https://github.com/ursacomputing/crossbow/branches/all?query=actions-577d37aa51) |Task|Status| ||--| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14431347765/job/40466507791)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org