Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-30 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2923000366

   @kou if you have the time to look at this one it would be appreciated. No 
rush - thanks as always!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-09 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2867936574

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-09 Thread via GitHub


github-actions[bot] commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2867939237

   Revision: 1d99f74832366fcc97d05b53f755d01b59a129ee
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-40712c0212](https://github.com/ursacomputing/crossbow/branches/all?query=actions-40712c0212)
   
   |Task|Status|
   ||--|
   |test-conda-cpp-meson|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-40712c0212-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/14938245741/job/41970554168)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-07 Thread via GitHub


github-actions[bot] commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2859638689

   Revision: b3852cf97711d680d1f8c92b397848b0b6a190e6
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-eca4b34981](https://github.com/ursacomputing/crossbow/branches/all?query=actions-eca4b34981)
   
   |Task|Status|
   ||--|
   |test-conda-cpp-meson|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-eca4b34981-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/14890014173/job/41819501794)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-07 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2859616320

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-07 Thread via GitHub


github-actions[bot] commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2859280017

   Revision: 6bc0d6cf784a6c504f17efb443edb756322e1dfa
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-fb9cb3520d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fb9cb3520d)
   
   |Task|Status|
   ||--|
   |test-conda-cpp-meson|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-fb9cb3520d-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/14888718297/job/41815147579)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-05-07 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2859271277

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


WillAyd commented on code in PR #46142:
URL: https://github.com/apache/arrow/pull/46142#discussion_r2042941821


##
cpp/meson.build:
##
@@ -24,7 +24,7 @@ project(
 meson_version: '>=1.3.0',
 default_options: [
 'buildtype=release',
-'c_std=c99',
+'c_std=gnu11,c11',

Review Comment:
   Namely it appears that c-ares wants to include macros from  and 
looks for macros like CLOCK_MONOTONIC from time.h on non-windows platforms



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2803029380

   I am not very familiar with Flight so apologies for any oversights, but I 
think this is a reasonable translation of the CMakeLists.txt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


WillAyd commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2803047158

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


github-actions[bot] commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2803052811

   Revision: 97138b8355543dc8375756c04167683bd3529d1d
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-9b43f97786](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9b43f97786)
   
   |Task|Status|
   ||--|
   |test-conda-cpp-meson|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9b43f97786-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/14455978036/job/40539205898)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


WillAyd commented on code in PR #46142:
URL: https://github.com/apache/arrow/pull/46142#discussion_r2042912834


##
cpp/meson.build:
##
@@ -24,7 +24,7 @@ project(
 meson_version: '>=1.3.0',
 default_options: [
 'buildtype=release',
-'c_std=c99',
+'c_std=gnu11,c11',

Review Comment:
   I bumped this to C11 as that is what the CMake configuration uses, but it 
also appears that the c-ares dependency requires some POSIX extensions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] GH-46141: Add flight directory to Meson configuration [arrow]

2025-04-14 Thread via GitHub


github-actions[bot] commented on PR #46142:
URL: https://github.com/apache/arrow/pull/46142#issuecomment-2802946631

   :warning: GitHub issue #46141 **has been automatically assigned in GitHub** 
to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]