Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
conbench-apache-arrow[bot] commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2857479842 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dc0972228448c8187629f03af1ff1c1d01b98ca3. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/41779473377) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
kou merged PR #46154: URL: https://github.com/apache/arrow/pull/46154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
github-actions[bot] commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2855852225 Revision: 02646ebabe48e96e55eb8ccace563e58d7ac7495 Submitted crossbow builds: [ursacomputing/crossbow @ actions-725472e915](https://github.com/ursacomputing/crossbow/branches/all?query=actions-725472e915) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14868864350/job/41752366941)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
WillAyd commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2855843933 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
github-actions[bot] commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2854936104 Revision: 02646ebabe48e96e55eb8ccace563e58d7ac7495 Submitted crossbow builds: [ursacomputing/crossbow @ actions-542871a8c4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-542871a8c4) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14863244113/job/41733399534)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
WillAyd commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2854927498 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
WillAyd commented on code in PR #46154:
URL: https://github.com/apache/arrow/pull/46154#discussion_r2075686844
##
cpp/src/arrow/acero/meson.build:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'accumulation_queue.h',
+'aggregate_node.h',
+'api.h',
+'asof_join_node.h',
+'backpressure_handler.h',
+'benchmark_util.h',
+'bloom_filter.h',
+'exec_plan.h',
+'hash_join_dict.h',
+'hash_join.h',
+'hash_join_node.h',
+'map_node.h',
+'options.h',
+'order_by_impl.h',
+'partition_util.h',
+'query_context.h',
+'schema_util.h',
+'task_util.h',
+'test_nodes.h',
+'time_series_util.h',
+'tpch_node.h',
+'type_fwd.h',
+'util.h',
+'visibility.h',
+],
+subdir: 'arrow/acero',
+)
+
+arrow_acero_srcs = [
+'accumulation_queue.cc',
+'scalar_aggregate_node.cc',
+'groupby_aggregate_node.cc',
+'aggregate_internal.cc',
+'asof_join_node.cc',
+'bloom_filter.cc',
+'exec_plan.cc',
+'fetch_node.cc',
+'filter_node.cc',
+'hash_join.cc',
+'hash_join_dict.cc',
+'hash_join_node.cc',
+'map_node.cc',
+'options.cc',
+'order_by_node.cc',
+'order_by_impl.cc',
+'partition_util.cc',
+'pivot_longer_node.cc',
+'project_node.cc',
+'query_context.cc',
+'sink_node.cc',
+'sorted_merge_node.cc',
+'source_node.cc',
+'swiss_join.cc',
+'task_util.cc',
+'time_series_util.cc',
+'tpch_node.cc',
+'union_node.cc',
+'util.cc',
+]
+
+arrow_acero_lib = library(
+'arrow-acero',
+sources: arrow_acero_srcs,
+dependencies: [arrow_dep],
+)
+
+arrow_acero_dep = declare_dependency(link_with: [arrow_acero_lib])
+
+arrow_acero_testing_sources = ['test_nodes.cc', 'test_util_internal.cc'] +
arrow_compute_testing_srcs
+
+arrow_acero_tests = {
+'plan-test': {'sources': ['plan_test.cc', 'test_nodes_test.cc']},
+'source-node-test': {'sources': ['source_node_test.cc']},
+'fetch-node-test': {'sources': ['fetch_node_test.cc']},
+'order-by-node-test': {'sources': ['order_by_node_test.cc']},
+'hash-join-node-test': {
+'sources': ['hash_join_node_test.cc', 'bloom_filter_test.cc'],
+},
+'pivot-longer-node-test': {'sources': ['pivot_longer_node_test.cc']},
+'asof-join-node-test': {'sources': ['asof_join_node_test.cc']},
+'sorted-merge-node-test': {'sources': ['sorted_merge_node_test.cc']},
+'tpch-node-test': {'sources': ['tpch_node_test.cc']},
+'union-node-test': {'sources': ['union_node_test.cc']},
+'aggregate-node-test': {'sources': ['aggregate_node_test.cc']},
+'util-test': {'sources': ['util_test.cc', 'task_util_test.cc']},
+'hash-aggregate-test': {'sources': ['hash_aggregate_test.cc']},
+'test-util-internal-test': {'sources': ['test_util_internal_test.cc']},
+}
+
+foreach key, val : arrow_acero_tests
+exc = executable(
+'arrow-acero-@0@'.format(key),
+sources: val['sources'] + arrow_acero_testing_sources,
+dependencies: [arrow_test_dep, arrow_acero_dep],
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
kou commented on code in PR #46154:
URL: https://github.com/apache/arrow/pull/46154#discussion_r2074347200
##
cpp/src/arrow/acero/meson.build:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'accumulation_queue.h',
+'aggregate_node.h',
+'api.h',
+'asof_join_node.h',
+'backpressure_handler.h',
+'benchmark_util.h',
+'bloom_filter.h',
+'exec_plan.h',
+'hash_join_dict.h',
+'hash_join.h',
+'hash_join_node.h',
+'map_node.h',
+'options.h',
+'order_by_impl.h',
+'partition_util.h',
+'query_context.h',
+'schema_util.h',
+'task_util.h',
+'test_nodes.h',
+'time_series_util.h',
+'tpch_node.h',
+'type_fwd.h',
+'util.h',
+'visibility.h',
+],
+subdir: 'arrow/acero',
+)
+
+arrow_acero_srcs = [
+'accumulation_queue.cc',
+'scalar_aggregate_node.cc',
+'groupby_aggregate_node.cc',
+'aggregate_internal.cc',
+'asof_join_node.cc',
+'bloom_filter.cc',
+'exec_plan.cc',
+'fetch_node.cc',
+'filter_node.cc',
+'hash_join.cc',
+'hash_join_dict.cc',
+'hash_join_node.cc',
+'map_node.cc',
+'options.cc',
+'order_by_node.cc',
+'order_by_impl.cc',
+'partition_util.cc',
+'pivot_longer_node.cc',
+'project_node.cc',
+'query_context.cc',
+'sink_node.cc',
+'sorted_merge_node.cc',
+'source_node.cc',
+'swiss_join.cc',
+'task_util.cc',
+'time_series_util.cc',
+'tpch_node.cc',
+'union_node.cc',
+'util.cc',
+]
+
+arrow_acero_lib = library(
+'arrow-acero',
+sources: arrow_acero_srcs,
+dependencies: [arrow_dep],
+)
+
+arrow_acero_dep = declare_dependency(link_with: [arrow_acero_lib])
+
+arrow_acero_testing_sources = ['test_nodes.cc', 'test_util_internal.cc'] +
arrow_compute_testing_srcs
+
+arrow_acero_tests = {
+'plan-test': {'sources': ['plan_test.cc', 'test_nodes_test.cc']},
+'source-node-test': {'sources': ['source_node_test.cc']},
+'fetch-node-test': {'sources': ['fetch_node_test.cc']},
+'order-by-node-test': {'sources': ['order_by_node_test.cc']},
+'hash-join-node-test': {
+'sources': ['hash_join_node_test.cc', 'bloom_filter_test.cc'],
+},
+'pivot-longer-node-test': {'sources': ['pivot_longer_node_test.cc']},
+'asof-join-node-test': {'sources': ['asof_join_node_test.cc']},
+'sorted-merge-node-test': {'sources': ['sorted_merge_node_test.cc']},
+'tpch-node-test': {'sources': ['tpch_node_test.cc']},
+'union-node-test': {'sources': ['union_node_test.cc']},
+'aggregate-node-test': {'sources': ['aggregate_node_test.cc']},
+'util-test': {'sources': ['util_test.cc', 'task_util_test.cc']},
+'hash-aggregate-test': {'sources': ['hash_aggregate_test.cc']},
+'test-util-internal-test': {'sources': ['test_util_internal_test.cc']},
+}
+
+foreach key, val : arrow_acero_tests
+exc = executable(
+'arrow-acero-@0@'.format(key),
+sources: val['sources'] + arrow_acero_testing_sources,
+dependencies: [arrow_test_dep, arrow_acero_dep],
Review Comment:
In general, `arrow_test_dep` should be placed after other Arrow related
`dep`s because `arrow_test_dep` depends on `arrow_dep`:
```suggestion
dependencies: [arrow_acero_dep, arrow_test_dep],
```
##
cpp/src/arrow/acero/meson.build:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
WillAyd commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2849288860 @kou if you have time to review this one, it looks like many of the remaining directories left to implement depend up on this. No rush of course - thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
github-actions[bot] commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2849280469 Revision: d806c95ff656df8eb4f6167f59d830129f4afd98 Submitted crossbow builds: [ursacomputing/crossbow @ actions-8f98bcb863](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8f98bcb863) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14822706354/job/41611830887)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
WillAyd commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2849279233 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46153: [C++] Implement acero directory in Meson [arrow]
github-actions[bot] commented on PR #46154: URL: https://github.com/apache/arrow/pull/46154#issuecomment-2808804046 :warning: GitHub issue #46153 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
