Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
conbench-apache-arrow[bot] commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2984659641 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bd31f83aaa93db8427bc90285658e29d79ce5efd. There were 119 benchmark results with an error: - Commit Run on `arm64-t4g-2xlarge-linux` at [2025-06-18 07:27:09Z](https://conbench.ursa.dev/compare/runs/c1af4fe47fc64b6791ec7c097e74cad7...25052631d18b4d6b8608545e4f9fe9eb/) - [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068527befdc27ad08000a531b341b473) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068527ca4bae746482c4eecfa40b) - and 117 more (see the report linked below) There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/44351858144) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2984239321 Thanks @kou for reviewing/merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
kou merged PR #46749: URL: https://github.com/apache/arrow/pull/46749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2982819478 > Do you have any idea how to maintain AIX support? We don't have any AIX CI jobs now. So AIX support may be broken in the feature. Is it acceptable? I will setup Jenkins CI job for AIX locally for this package and will build main branch on daily basis. If community can support , then we can provide AIX system where community can setup the CI. But not sure about complexity on setting this . So for time being, I am thinking to track AIX CI locally... Let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
kou commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2981922571 Do you have any idea how to maintain AIX support? We don't have any AIX CI jobs now. So AIX support may be broken in the feature. Is it acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2980390674 @kou What's next on this PR from my side. Please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2966104843 > https://github.com/apache/arrow/actions/runs/15561745991/job/43843132193?pr=46749#step:7:148 > > ``` > cpp/src/arrow/filesystem/localfs.cc:167: Use int16/int64/etc, rather than the C type long [runtime/int] [4] > ``` I missed to see this in lint report. Thanks for pointing out. Updated the code as suggested by lint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
kou commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2964798454 https://github.com/apache/arrow/actions/runs/15561745991/job/43843132193?pr=46749#step:7:148 ```text cpp/src/arrow/filesystem/localfs.cc:167: Use int16/int64/etc, rather than the C type long [runtime/int] [4] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2961435547 Hi @kou Lint is still failing without giving any details. Please let me know if anything is needed/missing from my side. ``` C++ Lint.Failed - hook id: cpplint - exit code: 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
ranjitshs commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2959410191 > Could you fix lint errors? > > How to maintain AIX support? See also: #46002 Thanks for suggestion about lint. I have updated the change. Let me know if any comments. Will go through https://github.com/apache/arrow/issues/46002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46748: [C++] Initial port on AIX [arrow]
kou commented on PR #46749: URL: https://github.com/apache/arrow/pull/46749#issuecomment-2957446377 Could you fix lint errors? How to maintain AIX support? See also: #46002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
