Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
conbench-apache-arrow[bot] commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2966774949 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e00c01a3fa4cc8ba098a637e3ba7e5ab5312cd0b. There were 71 benchmark results with an error: - Commit Run on `arm64-t4g-2xlarge-linux` at [2025-06-12 08:10:45Z](https://conbench.ursa.dev/compare/runs/428575f4859f4ccf9d3cc67c70db92e0...aa62c40c5b184e07af7e606ead73c9fd/) - [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0684a8c76fbe7bb98000136a69c4392e) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0684a8d2af39789a8000ec544abc4356) - and 69 more (see the report linked below) There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/43975599051) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
kou commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2964824162 Ah, `msys2_setup.sh` calls `ccache_setup.sh`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
kou commented on PR #46766:
URL: https://github.com/apache/arrow/pull/46766#issuecomment-2964826953
> `msys2_setup.sh` used by `.github/workflows/cpp.yml` and
`.github/workflows/ruby.yml`
>
> So I tried crossbow ruby and cpp
We don't use Crossbow for `.github/workflows/`. So we don't need to use
Crossbow here. Instead, we should run `.github/workflow/{cpp,ruby}.yml`:
```diff
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 8c4388fc0f..106cc1fd86 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -29,6 +29,7 @@ on:
- '.github/workflows/cpp.yml'
- 'ci/conda_env_*'
- 'ci/docker/**'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh'
- 'ci/scripts/install_gcs_testbench.sh'
@@ -45,6 +46,7 @@ on:
- '.github/workflows/cpp.yml'
- 'ci/conda_env_*'
- 'ci/docker/**'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh'
- 'ci/scripts/install_gcs_testbench.sh'
diff --git a/.github/workflows/cpp_extra.yml
b/.github/workflows/cpp_extra.yml
index 3df63568e9..e982afde91 100644
--- a/.github/workflows/cpp_extra.yml
+++ b/.github/workflows/cpp_extra.yml
@@ -27,6 +27,7 @@ on:
- '.github/workflows/cpp_extra.yml'
- 'ci/conda_env_*'
- 'ci/docker/**'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh'
- 'ci/scripts/install_gcs_testbench.sh'
@@ -45,6 +46,7 @@ on:
- '.github/workflows/cpp_extra.yml'
- 'ci/conda_env_*'
- 'ci/docker/**'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh'
- 'ci/scripts/install_gcs_testbench.sh'
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
index 8cb16049f0..af52e73320 100644
--- a/.github/workflows/ruby.yml
+++ b/.github/workflows/ruby.yml
@@ -29,6 +29,7 @@ on:
- '.github/workflows/ruby.yml'
- 'ci/docker/**'
- 'ci/scripts/c_glib_*'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/msys2_*'
- 'ci/scripts/ruby_*'
@@ -43,6 +44,7 @@ on:
- '.github/workflows/ruby.yml'
- 'ci/docker/**'
- 'ci/scripts/c_glib_*'
+ - 'ci/scripts/ccache_setup.sh'
- 'ci/scripts/cpp_*'
- 'ci/scripts/msys2_*'
- 'ci/scripts/ruby_*'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
kou commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2964822378 > `msys2_setup.sh` used by `.github/workflows/cpp.yml` and `.github/workflows/ruby.yml` Why is `msys2_setup.sh` related to this PR? This PR focus on `ccache_setup.sh`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
kou merged PR #46766: URL: https://github.com/apache/arrow/pull/46766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
hiroyuki-sato commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2964868312 Thanks. I applied suggested change. Should we separate `.github/workflow/*` change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
github-actions[bot] commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2961307129 Revision: 74cc885b4edefe8eb6097851addd157278184b04 Submitted crossbow builds: [ursacomputing/crossbow @ actions-4830b2d151](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4830b2d151) |Task|Status| ||--| |test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/15576829307/job/43863232410)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
hiroyuki-sato commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2961302754 @github-actions crossbow submit test-ubuntu-22.04-cpp-bundled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
hiroyuki-sato commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2959086730 `msys2_setup.sh` used by `.github/workflows/cpp.yml` and `.github/workflows/ruby.yml` So I tried crossbow ruby and cpp ``` rg -l 'ccache_setup.sh' ci/scripts/msys2_setup.sh rg -l 'msys2_setup.sh' .github/workflows/ .github/workflows/cpp.yml .github/workflows/ruby.yml ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46763: [CI][Dev] fix shellcheck errors in the ci/scripts/ccache_setup.sh [arrow]
github-actions[bot] commented on PR #46766: URL: https://github.com/apache/arrow/pull/46766#issuecomment-2958761887 Revision: 74cc885b4edefe8eb6097851addd157278184b04 Submitted crossbow builds: [ursacomputing/crossbow @ actions-efb3af9cc5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-efb3af9cc5) |Task|Status| ||--| |example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997998/job/43803228233)| |example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15557998156/job/43803228816)| |example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/15557998276/job/43803229368)| |test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997872/job/43803228033)| |test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997334/job/43803226217)| |test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997676/job/43803227351)| |test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997340/job/43803226246)| |test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997702/job/43803227195)| |test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/15557998128/job/43803228823)| |test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997981/job/43803228221)| |test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15557998085/job/43803228633)| |test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15557998172/job/43803228895)| |test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997508/job/43803226643)| |test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997500/job/43803226645)| |test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997809/job/43803227719)| |test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/15557997963/job/43803228286)| |test-ubuntu-24.04-cpp|[