Re: [PR] GH-46794: [CI][Dev] Fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
conbench-apache-arrow[bot] commented on PR #46795: URL: https://github.com/apache/arrow/pull/46795#issuecomment-2983380576 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e75ecdabbd148ead3a026e2dc0ef9756e1ef9e92. There were 119 benchmark results with an error: - Commit Run on `arm64-t4g-2xlarge-linux` at [2025-06-18 01:58:38Z](https://conbench.ursa.dev/compare/runs/b19d58c435154eb99854a4602ae14bcd...c1af4fe47fc64b6791ec7c097e74cad7/) - [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068522f5341c7b2b8000f5b24019d147) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/06852300a19779398000cc82d277095c) - and 117 more (see the report linked below) There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/44325338186) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46794: [CI][Dev] Fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
kou merged PR #46795: URL: https://github.com/apache/arrow/pull/46795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
hiroyuki-sato commented on PR #46795: URL: https://github.com/apache/arrow/pull/46795#issuecomment-2982197877 @assignUser Thank you for your advice. I'll try `-f` option. Could someone merge this PR if this PR no problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
assignUser commented on PR #46795:
URL: https://github.com/apache/arrow/pull/46795#issuecomment-2971405151
Thanks, great work!
Just making sure you know about this snippet to apply auto fixes
```bash
for file in "${files[@]}"; do
shellcheck -f diff $file | git apply
done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
hiroyuki-sato commented on PR #46795:
URL: https://github.com/apache/arrow/pull/46795#issuecomment-2969757449
@raulcd Thank you for your comment.
Now, I'm fixing files in the `ci/scripts` directory.
40/69 files passed.
Files with SCXXX(ex `ci/scripts/cpp_build.sh`) need to be modified.
After fixing all files in the `ci/scripts` direcotry, I'll try to change
like `ci/script/*.sh`,
Then will fix `cpp`, `dev` and ...
Finally removed all of files part.
Here is rough calculation per directories.
```
for i in $( find . -name '*.sh' -print ) ; do echo $i ; shellcheck $i |
grep -E -o 'SC[0-9]+' | sort -u | perl -pe '{ s/\n/ /}END{
print("\n"); }' ; done
```
| fail | directory |
|||
| 1 | c_glib |
| 71 | ci |
| 64 | cpp |
| 44 | dev |
| 5 | python |
| 3 | r |
| 2 | swift |
```
ci/scripts/c_glib_build.sh
ci/scripts/c_glib_test.sh
ci/scripts/ccache_setup.sh
ci/scripts/conan_build.sh
ci/scripts/conan_setup.sh
ci/scripts/cpp_build.sh
SC1090 SC1091 SC2007 SC2086 SC2155 SC2223 SC2236 SC2242
ci/scripts/cpp_test.sh
ci/scripts/csharp_build.sh
ci/scripts/csharp_pack.sh
ci/scripts/csharp_test.sh
SC2086 SC2155
ci/scripts/download_tz_database.sh
ci/scripts/install_azurite.sh
ci/scripts/install_ccache.sh
ci/scripts/install_ceph.sh
ci/scripts/install_chromedriver.sh
ci/scripts/install_cmake.sh
ci/scripts/install_conda.sh
ci/scripts/install_dask.sh
SC2086 SC2102
ci/scripts/install_emscripten.sh
ci/scripts/install_gcs_testbench.sh
SC2068 SC2154 SC2206 SC2223 SC2309
ci/scripts/install_iwyu.sh
ci/scripts/install_minio.sh
SC2046 SC2086
ci/scripts/install_ninja.sh
ci/scripts/install_numba.sh
SC1091 SC2086
ci/scripts/install_numpy.sh
ci/scripts/install_pandas.sh
ci/scripts/install_python.sh
ci/scripts/install_sccache.sh
SC2086 SC2166
ci/scripts/install_spark.sh
ci/scripts/install_vcpkg.sh
ci/scripts/integration_arrow_build.sh
ci/scripts/integration_arrow.sh
SC2046 SC2086 SC2102 SC2223
ci/scripts/integration_dask.sh
ci/scripts/integration_hdfs.sh
SC2034 SC2086 SC2155
ci/scripts/integration_skyhook.sh
SC2034 SC2086 SC2115 SC2143
ci/scripts/integration_spark.sh
ci/scripts/matlab_build.sh
ci/scripts/msys2_setup.sh
SC2086 SC2206
ci/scripts/msys2_system_clean.sh
ci/scripts/msys2_system_upgrade.sh
ci/scripts/nanoarrow_build.sh
ci/scripts/python_benchmark.sh
SC1091 SC2086 SC2164
ci/scripts/python_build_emscripten.sh
SC1090 SC2086
ci/scripts/python_build.sh
SC1091 SC2034 SC2086 SC2223 SC2236
ci/scripts/python_sdist_build.sh
ci/scripts/python_sdist_test.sh
SC1091 SC2012 SC2086
ci/scripts/python_test_emscripten.sh
SC2012 SC2086
ci/scripts/python_test.sh
SC1091 SC2034 SC2086 SC2223
ci/scripts/python_wheel_macos_build.sh
SC2006 SC2086 SC2155 SC2223
ci/scripts/python_wheel_unix_test.sh
ci/scripts/python_wheel_xlinux_build.sh
SC2002 SC2006 SC2045 SC2086 SC2223
ci/scripts/r_build.sh
ci/scripts/r_deps.sh
SC2006 SC2027 SC2086 SC2223
ci/scripts/r_docker_configure.sh
SC2006 SC2046 SC2086 SC2223
ci/scripts/r_install_system_dependencies.sh
SC2006 SC2223
ci/scripts/r_revdepcheck.sh
ci/scripts/r_sanitize.sh
SC2086 SC2155 SC2223
ci/scripts/r_test.sh
SC1091 SC2086 SC2223
ci/scripts/r_valgrind.sh
SC2046 SC2086 SC2223
ci/scripts/r_windows_build.sh
SC2011 SC2034 SC2035 SC2046 SC2086 SC2155 SC2223
ci/scripts/release_test.sh
ci/scripts/ruby_test.sh
ci/scripts/rust_build.sh
ci/scripts/swift_test.sh
SC2035 SC2086
ci/scripts/util_download_apache.sh
SC2048 SC2181
ci/scripts/util_enable_core_dumps.sh
ci/scripts/util_free_space.sh
ci/scripts/util_log.sh
ci/scripts/util_wait_for_it.sh
SC2046 SC2064 SC2086 SC2128 SC2206
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
raulcd commented on code in PR #46795: URL: https://github.com/apache/arrow/pull/46795#discussion_r2144558540 ## .pre-commit-config.yaml: ## @@ -305,6 +305,7 @@ repos: ?^ci/scripts/cpp_test\.sh$| ?^ci/scripts/csharp_build\.sh$| ?^ci/scripts/csharp_pack\.sh$| + ?^ci/scripts/csharp_test\.sh$| Review Comment: can we start using some type of regex instead of listing every file, for example all `ci/scripts/csharp*` should be run. Or do we plan to maintain this list of individual files until we can get rid of it completely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
hiroyuki-sato commented on PR #46795: URL: https://github.com/apache/arrow/pull/46795#issuecomment-2968555702 It seems that test failure in "C# / AMD64 macOS 13 C# 8.0.x (pull_request)" unrelated this change. https://github.com/apache/arrow/actions/runs/15611171739/job/43972190211?pr=46795#step:6:108 ``` Passed! - Failed: 0, Passed: 1450, Skipped: 0, Total: 1450, Duration: 5 s - Apache.Arrow.Tests.dll (net8.0) [xUnit.net 00:00:03.30] Apache.Arrow.Flight.Tests.FlightTests.EnsureCallRaisesRequestCancelled [FAIL] Failed Apache.Arrow.Flight.Tests.FlightTests.EnsureCallRaisesRequestCancelled [82 ms] Error Message: System.InvalidOperationException : Unable to get the status because the call is not complete. Stack Trace: at Grpc.Net.Client.Internal.GrpcCall`2.GetStatus() at Grpc.Net.Client.Internal.HttpClientCallInvoker.Callbacks`2.<>c.<.cctor>b__4_1(Object state) at Grpc.Core.AsyncCallState.GetStatus() at Grpc.Core.AsyncServerStreamingCall`1.GetStatus() at Grpc.Core.AsyncCallState.GetStatus() at Grpc.Core.AsyncServerStreamingCall`1.GetStatus() at Apache.Arrow.Flight.Tests.FlightTests.EnsureCallRaisesRequestCancelled() in /Users/runner/work/arrow/arrow/csharp/test/Apache.Arrow.Flight.Tests/FlightTests.cs:line 523 --- End of stack trace from previous location --- ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]
github-actions[bot] commented on PR #46795: URL: https://github.com/apache/arrow/pull/46795#issuecomment-2966573027 :warning: GitHub issue #46794 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
