Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
conbench-apache-arrow[bot] commented on PR #46990: URL: https://github.com/apache/arrow/pull/46990#issuecomment-3056128848 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27cca0ff593392c7ba9937e795e008379c3376d4. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/45700963708) has more details. It also includes information about 30 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
kou merged PR #46990: URL: https://github.com/apache/arrow/pull/46990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
kou commented on PR #46990: URL: https://github.com/apache/arrow/pull/46990#issuecomment-3054781788 I'll merge this for 21.0.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
amoeba commented on code in PR #46990: URL: https://github.com/apache/arrow/pull/46990#discussion_r2191389421 ## docs/source/developers/cpp/building.rst: ## @@ -39,7 +39,7 @@ out-of-source. If you are not familiar with this terminology: Building requires: -* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be +* A C++17-enabled compiler. On Linux, gcc 9 and higher should be Review Comment: [Issue](https://github.com/apache/arrow/issues/47025) and [PR](https://github.com/apache/arrow/pull/47026). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
kou commented on code in PR #46990: URL: https://github.com/apache/arrow/pull/46990#discussion_r2191341141 ## docs/source/developers/cpp/building.rst: ## @@ -39,7 +39,7 @@ out-of-source. If you are not familiar with this terminology: Building requires: -* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be +* A C++17-enabled compiler. On Linux, gcc 9 and higher should be Review Comment: If you can do it, it's helpful. (Anyway, I can do it later.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
amoeba commented on code in PR #46990: URL: https://github.com/apache/arrow/pull/46990#discussion_r2191319370 ## docs/source/developers/cpp/building.rst: ## @@ -39,7 +39,7 @@ out-of-source. If you are not familiar with this terminology: Building requires: -* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be +* A C++17-enabled compiler. On Linux, gcc 9 and higher should be Review Comment: Thanks. Let me know if you want me to file an issue+PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
kou commented on code in PR #46990: URL: https://github.com/apache/arrow/pull/46990#discussion_r2191316064 ## docs/source/developers/cpp/building.rst: ## @@ -39,7 +39,7 @@ out-of-source. If you are not familiar with this terminology: Building requires: -* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be +* A C++17-enabled compiler. On Linux, gcc 9 and higher should be Review Comment: OK. Let's revert this: ```suggestion * A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
amoeba commented on code in PR #46990: URL: https://github.com/apache/arrow/pull/46990#discussion_r2191127453 ## docs/source/developers/cpp/building.rst: ## @@ -39,7 +39,7 @@ out-of-source. If you are not familiar with this terminology: Building requires: -* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be +* A C++17-enabled compiler. On Linux, gcc 9 and higher should be Review Comment: What do you think about making this change in a separate issue and PR so it's more visible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
pitrou commented on PR #46990: URL: https://github.com/apache/arrow/pull/46990#issuecomment-3041196133 I'm strongly in favor of requiring GCC 9. We recently [reached consensus](https://lists.apache.org/thread/48zlj0dn2y0f53y2k37qsr90y781wfnj) in favor of switching to C++20, so we will need at least that version anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 [arrow]
kou commented on PR #46990: URL: https://github.com/apache/arrow/pull/46990#issuecomment-3040244916 @Ziy1-Tan @pitrou Do you think that we can use GCC 7 compatible implementation for #46813? Or should we require GCC 9 (8?) or later like this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
