Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
zhjwpku commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3047053106 > You can ignore this. > > Unfortunately, our continuous benchmarking mechanism is broken recently... Sure, thanks for confirming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
kou commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3046964154 You can ignore this. Unfortunately, our continuous benchmarking mechanism is broken recently... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
zhjwpku commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3044868208 > After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit [1e01c52](https://github.com/apache/arrow/commit/1e01c520e9fb4ffddedeb7179d99a8cacfb9d347). > > There were 3 benchmark results indicating a performance regression: > > * Commit Run on `test-mac-arm` at [2025-07-07 06:41:51Z](https://conbench.ursa.dev/compare/runs/729e6817da914505a3e1fa474bbda8e6...ab10508f7f9d4e27b7feb05aeae6c788/) > > * [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0686a6b5ddd674f28000832372e7c4b9...0686b771feba77948000ac3209cb66b7) > * [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0686a6bb8deb7b8280008da195e99b3d...0686b777c38d7c1d80003613ed1787e5) > * and 1 more (see the report linked below) > > The [full Conbench report](https://github.com/apache/arrow/runs/45470355740) has more details. It also includes information about 54 possible false positives for unstable benchmarks that are known to sometimes produce them. I don't quite understand why these performance regression, do these cases use mockfs? Kou san, can you give me some hints how to diagnose this? @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
conbench-apache-arrow[bot] commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3044687294 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1e01c520e9fb4ffddedeb7179d99a8cacfb9d347. There were 3 benchmark results indicating a performance regression: - Commit Run on `test-mac-arm` at [2025-07-07 06:41:51Z](https://conbench.ursa.dev/compare/runs/729e6817da914505a3e1fa474bbda8e6...ab10508f7f9d4e27b7feb05aeae6c788/) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0686a6b5ddd674f28000832372e7c4b9...0686b771feba77948000ac3209cb66b7) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0686a6bb8deb7b8280008da195e99b3d...0686b777c38d7c1d80003613ed1787e5) - and 1 more (see the report linked below) The [full Conbench report](https://github.com/apache/arrow/runs/45470355740) has more details. It also includes information about 54 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
kou merged PR #46999: URL: https://github.com/apache/arrow/pull/46999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with C++23 [arrow]
zhjwpku commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3043477324 > +1 > > Could you use our PR template instead of removing it entirely? We use the PR title and description for commit message on merge. I've done that, can you see it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with c++23 [arrow]
zhjwpku commented on code in PR #46999:
URL: https://github.com/apache/arrow/pull/46999#discussion_r2187324967
##
cpp/src/arrow/filesystem/mockfs.cc:
##
@@ -187,6 +184,11 @@ class Entry : public EntryBase {
ARROW_DISALLOW_COPY_AND_ASSIGN(Entry);
};
+void Directory::AssignEntry(const std::string& s, std::unique_ptr
entry) {
Review Comment:
The AssignEntry implementation is now placed after the full definition of
Entry so it can access its structure. Previously, Entry was only forward
declared, and as the error message indicated, the `sizeof` a forward
declaration is 0, which triggered the static_assert.
I'm not sure this is the most appropriate fix, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with c++23 [arrow]
wgtmac commented on code in PR #46999:
URL: https://github.com/apache/arrow/pull/46999#discussion_r2187306529
##
cpp/src/arrow/filesystem/mockfs.cc:
##
@@ -187,6 +184,11 @@ class Entry : public EntryBase {
ARROW_DISALLOW_COPY_AND_ASSIGN(Entry);
};
+void Directory::AssignEntry(const std::string& s, std::unique_ptr
entry) {
Review Comment:
I don't quite understand how does this fix the issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46998: [C++] Fix mockfs.cc compiling error with c++23 [arrow]
github-actions[bot] commented on PR #46999: URL: https://github.com/apache/arrow/pull/46999#issuecomment-3038843442 :warning: GitHub issue #46998 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
