Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
conbench-apache-arrow[bot] commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3150919265 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2cbf1227939d42cb08998eb8fa666120c44ff254. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The [full Conbench report](https://github.com/apache/arrow/runs/47340756626) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
rok commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3150327721 Opened #47255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
rok commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3150104399 Although if we have a dependency free test data generator we would probably want to use it everywhere. And in that case we probably want to spend the time to connect to the cpp generator we already have in place for cpp testing for Python testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
rok commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3150089801 > Thanks for the PR! I would have loved to see an utility function that does not require neither pandas nor numpy so we can reuse on our tests without numpy too, basically have a no extra requirements fixture (only python and pyarrow) so we don't require anything else. Maybe we could create a follow up issue? Agreed! The only question in my mind here is do we expose a cpp utility for generating random array data or use Python stdlib. I think for small data sizes Python stdlib would be quite sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
egolearner commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3149890309 Thanks again for your review @rok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
rok commented on PR #47199: URL: https://github.com/apache/arrow/pull/47199#issuecomment-3149621120 Thank you for working this @egolearner! It's a nice improvement and should improve test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-47172: [Python] Add a utility function to create Arrow table instead of pandas df [arrow]
rok merged PR #47199: URL: https://github.com/apache/arrow/pull/47199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
