Re: [PR] GH-48234: [C++][Parquet] Fix overly strict check for BIT_PACKED levels byte size [arrow]
conbench-apache-arrow[bot] commented on PR #48235: URL: https://github.com/apache/arrow/pull/48235#issuecomment-3576348551 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 52d258b27a9379aef683479e13b3c051982204e8. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/56355859305) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-48234: [C++][Parquet] Fix overly strict check for BIT_PACKED levels byte size [arrow]
pitrou merged PR #48235: URL: https://github.com/apache/arrow/pull/48235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-48234: [C++][Parquet] Fix overly strict check for BIT_PACKED levels byte size [arrow]
pitrou commented on PR #48235: URL: https://github.com/apache/arrow/pull/48235#issuecomment-3574390157 I'll merge now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-48234: [C++][Parquet] Fix overly strict check for BIT_PACKED levels byte size [arrow]
pitrou commented on PR #48235: URL: https://github.com/apache/arrow/pull/48235#issuecomment-3569855773 > I give a quick glance and this is ok to me, but I may need some time to find out why it doesn't trigger any bug previously... Probably because `data_size` is the entire page size, and it also contains the page values. It's rare for page values to take less than 4 bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-48234: [C++][Parquet] Fix overly strict check for BIT_PACKED levels byte size [arrow]
github-actions[bot] commented on PR #48235: URL: https://github.com/apache/arrow/pull/48235#issuecomment-3569841726 Revision: 0390720b915ebca9d68695ead2fbfb828c828a46 Submitted crossbow builds: [ursacomputing/crossbow @ actions-d4511141a8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d4511141a8) |Task|Status| ||--| |example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105497/job/56207567447)| |example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105244/job/56207566560)| |example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105846/job/56207568588)| |test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105042/job/56207565792)| |test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105679/job/56207568034)| |test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/19630104861/job/56207565146)| |test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/19630104844/job/56207565032)| |test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105533/job/56207567459)| |test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105467/job/56207567421)| |test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105291/job/56207566644)| |test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105969/job/56207568955)| |test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105182/job/56207566282)| |test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105132/job/56207566110)| |test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105802/job/56207568488)| |test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/19630105817/job/56207568512)| |test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19630104888/job/56207565302)| |test-ubuntu-24.04-cpp-bundled-offline|[