Re: [PR] MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0 [arrow-java]

2026-05-09 Thread via GitHub 


jbonofre merged PR #1140:
URL: https://github.com/apache/arrow-java/pull/1140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0 [arrow-java]

2026-05-07 Thread via GitHub 


jbonofre commented on code in PR #1140:
URL: https://github.com/apache/arrow-java/pull/1140#discussion_r3206232194


##
ci/scripts/jni_manylinux_build.sh:
##
@@ -74,7 +74,10 @@ cmake \
   -S "${arrow_dir}/cpp" \
   -B "${build_dir}/cpp" \
   --preset=ninja-release-jni-linux \
-  -DCMAKE_INSTALL_PREFIX="${install_dir}"
+  -DCMAKE_INSTALL_PREFIX="${install_dir}" \
+  -DCMAKE_TOOLCHAIN_FILE="${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake" \
+  -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
+  -Dxsimd_SOURCE=BUNDLED

Review Comment:
   Good point. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0 [arrow-java]

2026-05-07 Thread via GitHub 


kou commented on code in PR #1140:
URL: https://github.com/apache/arrow-java/pull/1140#discussion_r3205563324


##
ci/scripts/jni_manylinux_build.sh:
##
@@ -74,7 +74,10 @@ cmake \
   -S "${arrow_dir}/cpp" \
   -B "${build_dir}/cpp" \
   --preset=ninja-release-jni-linux \
-  -DCMAKE_INSTALL_PREFIX="${install_dir}"
+  -DCMAKE_INSTALL_PREFIX="${install_dir}" \
+  -DCMAKE_TOOLCHAIN_FILE="${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake" \
+  -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
+  -Dxsimd_SOURCE=BUNDLED

Review Comment:
   Could you update 
https://github.com/apache/arrow-java/blob/0f0a58433b46004ff9869a2512beded177340bca/.env#L56
 to synchronize with 
https://github.com/apache/arrow/blob/a0d2885b101acb439f7f79ec2237028974e74e64/.env#L95
 instead of `-Dxsimd_SOURCE=BUNDLED`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]