Re: [PR] Run CI on PRs [arrow-rs-object-store]

2025-04-15 Thread via GitHub


alamb merged PR #336:
URL: https://github.com/apache/arrow-rs-object-store/pull/336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Run CI on PRs [arrow-rs-object-store]

2025-04-15 Thread via GitHub


alamb commented on PR #336:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/336#issuecomment-2807265879

   We run tests, sure we do. Thank you very much @AdamGS 
   
   
![image](https://github.com/user-attachments/assets/88b5d973-1037-415f-a2e9-9351e1de8c97)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Run CI on PRs [arrow-rs-object-store]

2025-04-15 Thread via GitHub


alamb commented on PR #336:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/336#issuecomment-2807245775

   🤞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Run CI on PRs [arrow-rs-object-store]

2025-04-15 Thread via GitHub


alamb commented on PR #336:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/336#issuecomment-2807242955

   ![Screenshot 2025-04-15 at 3 18 46 
PM](https://github.com/user-attachments/assets/77959789-5921-426b-bf67-d1396438a2aa)
   
   ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Run CI on PRs [arrow-rs-object-store]

2025-04-15 Thread via GitHub


alamb commented on code in PR #336:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/336#discussion_r2045299015


##
.github/workflows/ci.yml:
##
@@ -30,7 +30,8 @@ on:
   - main
   pull_request:
 paths:
-  - object_store/**
+  - src/**

Review Comment:
   we can probably simplify this and not even have a path filter. But this is 
good too 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org