Re: [PR] chore(csharp): fix typo [arrow-adbc]
CurtHagenlocher merged PR #3002: URL: https://github.com/apache/arrow-adbc/pull/3002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(csharp): fix typo [arrow-adbc]
daipom commented on PR #2933: URL: https://github.com/apache/arrow-adbc/pull/2933#issuecomment-2955570192 Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(csharp): fix typo [arrow-adbc]
CurtHagenlocher commented on PR #2933: URL: https://github.com/apache/arrow-adbc/pull/2933#issuecomment-2955525758 > However, I can't confirm some `Drivers` tests. (I believe that this PR does not affect the test results though.) It appears that they need some env vars and preparation, but I don't know how. Yeah, most of the driver tests require access to the data source -- which means an account with credentials, which has a lot of challenges for CI. But we really should have instructions which would allow someone to manually configure an account and run the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(csharp): fix typo [arrow-adbc]
CurtHagenlocher merged PR #2933: URL: https://github.com/apache/arrow-adbc/pull/2933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(csharp): fix typo [arrow-adbc]
daipom commented on PR #2933: URL: https://github.com/apache/arrow-adbc/pull/2933#issuecomment-2955372945 I have confirmed the following. * Build success. * `Apache.Arrow.Adbc.Tests` success. However, I can't confirm some `Drivers` tests. (I believe that this PR does not affect the test results though.) It appears that they need some env vars and preparation, but I don't know how. https://github.com/apache/arrow-adbc/blob/443037930c5eabd5922efb3eb0fc5d2303a19067/csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs#L41-L44 https://github.com/apache/arrow-adbc/blob/443037930c5eabd5922efb3eb0fc5d2303a19067/csharp/test/Apache.Arrow.Adbc.Tests/Utils.cs#L46-L65 It seems there’s no documentation, and no CI either (except for `Apache.Arrow.Adbc.Tests`). I'm happy to contribute to the development of this area as well if that helps. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
