Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.227.0 to 0.228.0 in /go/adbc [arrow-adbc]
zeroshade merged PR #2659: URL: https://github.com/apache/arrow-adbc/pull/2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.227.0 to 0.228.0 in /go/adbc [arrow-adbc]
dependabot[bot] commented on PR #2659: URL: https://github.com/apache/arrow-adbc/pull/2659#issuecomment-2802967411 A newer version of google.golang.org/api exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.227.0 to 0.228.0 in /go/adbc [arrow-adbc]
lidavidm commented on PR #2659: URL: https://github.com/apache/arrow-adbc/pull/2659#issuecomment-2772503233 @zeroshade wanna take a look here and make sure I didn't screw anything up? It's a mix of automatic changes from golangci-lint and manual changes to satisfy the new lints -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.227.0 to 0.228.0 in /go/adbc [arrow-adbc]
lidavidm commented on PR #2659: URL: https://github.com/apache/arrow-adbc/pull/2659#issuecomment-2768108755 Ugh. @zeroshade staticcheck needs to be built with Go 1.24 to check some files in this dep, so I bumped the Go version, which required bumping golangci-lint, which (1) made a bunch of edits (mostly changing if/else chains into switch statements) (2) now errors on a lot of cases where we forget to check the result of `defer foo.Close()` in tests, so this will take a bit of work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.227.0 to 0.228.0 in /go/adbc [arrow-adbc]
lidavidm commented on PR #2659: URL: https://github.com/apache/arrow-adbc/pull/2659#issuecomment-2767675640 Seems this broke because of https://github.com/actions/setup-go/issues/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org