Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2855214893 Thanks again @ion-elgreco for helping push this over the line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb merged PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2855214232 I think we are ready , let's merge this in@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2855137912 I am looking at the WASM issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
ion-elgreco commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2844507987 @alamb resolved the merge conflict with the new `Zed` merge conflict functionality :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2836100751 > This appears to have accumulated some merge conflicts I'll try and fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
tustvold commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2818752153 This appears to have accumulated some merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on PR #332: URL: https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2813974107 I am out starting tomorrow for a week, so if another committer doesn't merge this before I will do so when I get back Thanks again @ion-elgreco -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add `SpawnService` and `SpawnedReqwestConnector` for running requests on a different runtime [arrow-rs-object-store]
alamb commented on code in PR #332:
URL:
https://github.com/apache/arrow-rs-object-store/pull/332#discussion_r2045452723
##
src/aws/mod.rs:
##
@@ -820,4 +821,54 @@ mod tests {
store.delete(location).await.unwrap();
}
}
+
+/// Integration test that ensures I/O is done on an alternate threadpool
+/// when using the `SpawnedReqwestConnector`.
+#[test]
Review Comment:
I also wrote this end to end integration test to ensure that everything
worked correctly when hooked up to an ObjectStore implementation (and it does!)
##
src/aws/mod.rs:
##
@@ -820,4 +821,54 @@ mod tests {
store.delete(location).await.unwrap();
}
}
+
+/// Integration test that ensures I/O is done on an alternate threadpool
+/// when using the `SpawnedReqwestConnector`.
+#[test]
+fn s3_alternate_threadpool_spawned_request_connector() {
+maybe_skip_integration!();
+let (shutdown_tx, shutdown_rx) = tokio::sync::oneshot::channel::<()>();
+
+// Runtime with I/O enabled
+let io_runtime = tokio::runtime::Builder::new_current_thread()
+.enable_all() // <-- turns on IO
Review Comment:
if you comment out this line the test fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
