Re: [PR] fix(go/adbc): moving the declaration of functions to go code [arrow-adbc]
howareyouman commented on PR #3079: URL: https://github.com/apache/arrow-adbc/pull/3079#issuecomment-3036869477 @zeroshade I've created new go file with functions, removed _tmpl generated files from the repo (I don't know why we had them in the repo?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc): moving the declaration of functions to go code [arrow-adbc]
zeroshade commented on PR #3079: URL: https://github.com/apache/arrow-adbc/pull/3079#issuecomment-3036721355 The generation doesn't remove and recreate the directory, we just create the files. So you can just make a new file in the `pkg/flightsql` directory which contains the functions. That way they don't get overwritten during generation, but are still part of the package that they rely on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc): moving the declaration of functions to go code [arrow-adbc]
howareyouman commented on PR #3079: URL: https://github.com/apache/arrow-adbc/pull/3079#issuecomment-3036708905 @zeroshade I see that these 2 functions heavily rely on C layer, which lives in the pkg folder, and the dependency between folders is pkg(generated) -> driver(not generated). I don't understand how to remove them from the generation step if we want to expose them in the shared library, and they rely on generated code? What should be done here then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc): moving the declaration of functions to go code [arrow-adbc]
zeroshade commented on PR #3079: URL: https://github.com/apache/arrow-adbc/pull/3079#issuecomment-3024787930 @howareyouman the `driver.go` is also generated by code generation, with the goal of avoiding losing the functions during code-gen it needs to be a separate file from driver.go/utils.c/utils.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
