Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm merged PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2766032409 Looks like the snowflake PR merged, I will try and bump (temporarily) to see if it does fix the issue here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2762795512 > Do we expose setting the log level anywhere in the API? > > Should we? I looked at it, but the struggle is that we have a per-database log level and Snowflake has a global logger. Maybe we can config a separate logger per Snowflake connection though. But for now I figured we should just set this (even though it doesn't help) and wait for Snowflake to fix the underlying issue upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2731419202 @zeroshade any comments here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2720306988 FWIW Dewey, it seems the PR where Snowflake is fixing this is primarily adding some file-based cache of auth tokens...so we might just be trading one problem for another (if stray files are a concern for CRAN) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
paleolimbot commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2721195839 Thanks for the heads up! We don't submit this one to CRAN and so it's fine, and even if we did, the problem is only if a file gets created when constructing a global (creating files during connection, while theoretically frowned upon by CRAN, is not something they would be able to detect because we very reasonably can't create a connection when running the tests on their servers). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2719530764 Hmm, seems Snowflake has a global logger + it's pretty tied to the logrus interface; might not be good to bridge the two by default. Going to leave this PR as-is then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2719510981 Ah, that's what I was vaguely remembering. That seems to be a different code path but I suppose the same line of thinking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
paleolimbot commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2719489578 Thanks for looking into this! A while back I patched gosnowflake specifically for a CRAN submission because it was creating files when initializing a global (maybe the same one). If useful, the patch is here: https://github.com/apache/arrow-adbc/issues/1315#issuecomment-1824815421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(go/adbc/driver/snowflake): try to suppress stray logs [arrow-adbc]
lidavidm commented on PR #2608: URL: https://github.com/apache/arrow-adbc/pull/2608#issuecomment-2719454358 The one thing I can do here is wire up the snowflake logger to the ADBC logger at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
