Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
lidavidm commented on PR #2700: URL: https://github.com/apache/arrow-adbc/pull/2700#issuecomment-2800231285 Thanks for the PR. Let me debug what's going on and I'll file a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
lidavidm merged PR #2700: URL: https://github.com/apache/arrow-adbc/pull/2700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
fwojciec commented on PR #2700: URL: https://github.com/apache/arrow-adbc/pull/2700#issuecomment-2803955371 Hi @lidavidm, Done! I've rebased this branch onto the latest main and force-pushed the update. Confirmed locally that all tests are passing now. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
lidavidm commented on PR #2700: URL: https://github.com/apache/arrow-adbc/pull/2700#issuecomment-2803614283 Ok, if you rebase things should be fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
fwojciec commented on PR #2700: URL: https://github.com/apache/arrow-adbc/pull/2700#issuecomment-2802590898 I've updated the test in this PR to include your change from the comment above - and uncommented it. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect [arrow-adbc]
lidavidm commented on PR #2700:
URL: https://github.com/apache/arrow-adbc/pull/2700#issuecomment-2800619591
See https://github.com/apache/arrow-adbc/pull/2701 (I need to add some tests)
Also, I had to tweak the test:
```
+with dbapi.connect(postgres_uri, conn_kwargs={schema_key: schema_name})
as conn:
+option_value = conn.adbc_connection.get_option(schema_key)
+assert option_value == schema_name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
