Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
hnwyllmm commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2907712247 > > > Is it possible to add a test? > > > > > > I'll try to add a test case in `integration_tests.py`. > > Do you need an integration test? IMO, you should be able to export a stream, then immediately import it, all within Java. I add a unittest but I think it can't make sure `TryCopyLastError` works correctly, so I suggest it should be removed. We can read memory after the error string address in most cases. We usually check such problems by sanity tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
kou commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2906090380 Thanks. (We've fixed this problem in apache/arrow. Sorry for not sharing it here...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
hnwyllmm commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2905095542 > > The error message in CI doesn't seem to be related to my PR: > > ``` > > /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -lutf8proc > > collect2: error: ld returned 1 exit status > > ``` > > > > > > linkage: https://github.com/apache/arrow-java/actions/runs/15140171347/job/42594091462?pr=760 > > Do you have some suggestions? > > Could you open a separated issue for it? Let's fix it as a separated task. issue: #767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
lidavidm commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2896399246 > > Is it possible to add a test? > > I'll try to add a test case in `integration_tests.py`. Do you need an integration test? IMO, you should be able to export a stream, then immediately import it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
kou commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2896248990 > The error message in CI doesn't seem to be related to my PR: > > ``` > /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -lutf8proc > collect2: error: ld returned 1 exit status > ``` > > linkage: https://github.com/apache/arrow-java/actions/runs/15140171347/job/42594091462?pr=760 > > Do you have some suggestions? Could you open a separated issue for it? Let's fix it as a separated task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
hnwyllmm commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2896238789 > Is it possible to add a test? I'll try to add a test case in `integration_tests.py`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix get length of byte[] in TryCopyLastError [arrow-java]
hnwyllmm commented on PR #760: URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2896233817 The error message in CI doesn't seem to be related to my PR: ```text /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -lutf8proc collect2: error: ld returned 1 exit status ``` linkage: https://github.com/apache/arrow-java/actions/runs/15140171347/job/42594091462?pr=760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
