Re: [I] native_iceberg_compat uses hard-coded config values [datafusion-comet]

2026-05-19 Thread via GitHub 


mbutrovich commented on issue #1816:
URL: 
https://github.com/apache/datafusion-comet/issues/1816#issuecomment-4490751430

   Closed by #4363.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [I] native_iceberg_compat uses hard-coded config values [datafusion-comet]

2026-05-19 Thread via GitHub 


mbutrovich closed issue #1816: native_iceberg_compat uses hard-coded config 
values
URL: https://github.com/apache/datafusion-comet/issues/1816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[I] native_iceberg_compat uses hard-coded config values [datafusion-comet]

2025-05-29 Thread via GitHub 


parthchandra opened a new issue, #1816:
URL: https://github.com/apache/datafusion-comet/issues/1816

   ### Describe the bug
   
   In native_iceberg_compat, the initialization had codes the following 
configuration flags - 
   ```
   conf.set("spark.sql.parquet.binaryAsString", "false");
   conf.set("spark.sql.parquet.int96AsTimestamp", "true");
   conf.set("spark.sql.caseSensitive", "false");
   conf.set("spark.sql.parquet.inferTimestampNTZ.enabled", "true");
   conf.set("spark.sql.legacy.parquet.nanosAsLong", "false");
   ```
   These explicitly set the config to the default values for the configs. 
   We should apply the values specified by the end user instead and use 
defaults only if the value is not provided.
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]