Re: [I] panic: generate_series table function overflows when integer step passes i64::MAX [datafusion]

2026-07-20 Thread via GitHub


xiedeyantu commented on issue #22208:
URL: https://github.com/apache/datafusion/issues/22208#issuecomment-5023519639

   @u70b3 Please don't @ me. I won't be contributing to DataFusion anymore. Do 
whatever you want with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] panic: generate_series table function overflows when integer step passes i64::MAX [datafusion]

2026-07-20 Thread via GitHub


u70b3 commented on issue #22208:
URL: https://github.com/apache/datafusion/issues/22208#issuecomment-5022922969

   FYI: I'm picking this up since the previous attempt #22250 was closed 
unmerged by its author on 2026-06-04. My PR follows the approach that was 
approved there (stop after the last reachable value, matching 
PostgreSQL/DuckDB) and also fixes #22193 in the same file. cc @xiedeyantu in 
case you had work in progress here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] panic: generate_series table function overflows when integer step passes i64::MAX [datafusion]

2026-05-16 Thread via GitHub


xiedeyantu commented on issue #22208:
URL: https://github.com/apache/datafusion/issues/22208#issuecomment-4467251838

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[I] panic: generate_series table function overflows when integer step passes i64::MAX [datafusion]

2026-05-15 Thread via GitHub


Dandandan opened a new issue, #22208:
URL: https://github.com/apache/datafusion/issues/22208

   ### Describe the bug
   
   The table-valued `generate_series(start, stop, step)` can panic when the 
integer iterator advances past `i64::MAX` while evaluating user SQL.
   
   ### To Reproduce
   
   ```sql
   SELECT * FROM generate_series(9223372036854775806, 9223372036854775807, 2);
   ```
   
   ### Actual behavior
   
   `datafusion-cli` panics:
   
   ```text
   thread 'main' panicked at 
datafusion/functions-table/src/generate_series.rs:101:9:
   attempt to add with overflow
   ```
   
   ### Expected behavior
   
   DataFusion should return a normal execution error or stop iteration without 
panicking.
   
   ### Notes
   
   This is distinct from the already-filed capacity-overflow issue for scalar 
`range`/`generate_series`; this panic is the table function's iterator doing 
unchecked `current + step`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]