Re: [PR] Add comments to physical optimizer tests [datafusion]

2025-01-10 Thread via GitHub


jayzhan211 merged PR #14075:
URL: https://github.com/apache/datafusion/pull/14075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org



Re: [PR] Add comments to physical optimizer tests [datafusion]

2025-01-10 Thread via GitHub


jayzhan211 commented on PR #14075:
URL: https://github.com/apache/datafusion/pull/14075#issuecomment-2585039343

   Thanks @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org



[PR] Add comments to physical optimizer tests [datafusion]

2025-01-10 Thread via GitHub


alamb opened a new pull request, #14075:
URL: https://github.com/apache/datafusion/pull/14075

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion/issues/11502
   
   ## Rationale for this change
   
   I tried to move some of these tests to be with the code they are testing, 
but found out the reason is the dependency on ParquetExec
   
   ## What changes are included in this PR?
   
   Add comments explaining this rationale so it is clearer to the next reader
   
   ## Are these changes tested?
   
   
   
   ## Are there any user-facing changes?
   No
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org