Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
alamb commented on PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890#issuecomment-2983657757 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
iffyio merged PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
git-hulk commented on PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890#issuecomment-2982349184 @iffyio, I've changed the link to the Markdown style now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
iffyio commented on PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890#issuecomment-2980994790 @git-hulk could you take a look at the ci failure when you get the chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
git-hulk commented on PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890#issuecomment-2980099957 @iffyio Thanks for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
iffyio commented on code in PR #1890:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1890#discussion_r2151983259
##
tests/sqlparser_bigquery.rs:
##
@@ -2407,3 +2459,16 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_generic().verified_stmt("CREATE TABLE foo (x ANY)");
}
+
+#[test]
+fn test_allow_options_in_struct_field() {
Review Comment:
```suggestion
fn test_struct_field_options() {
```
##
src/ast/mod.rs:
##
@@ -428,14 +428,22 @@ impl fmt::Display for Interval {
pub struct StructField {
pub field_name: Option,
pub field_type: DataType,
+// BigQuery supports options for struct fields.
+// see [BigQuery]:
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
Review Comment:
```suggestion
/// Struct field options.
/// see [BigQuery]:
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
git-hulk commented on PR #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890#issuecomment-2978804373 cc @iffyio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] Add support of parsing struct field's options in BigQuery [datafusion-sqlparser-rs]
git-hulk opened a new pull request, #1890: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1890 According to BigQuery syntax[1], the `OPTIONS` is allowed in both of top-level column definition and struct field. [1] https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
