Re: [PR] Fix join precedence for non-snowflake queries [datafusion-sqlparser-rs]
iffyio merged PR #1905: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix join precedence for non-snowflake queries [datafusion-sqlparser-rs]
iffyio commented on code in PR #1905:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1905#discussion_r2173481353
##
src/dialect/mod.rs:
##
@@ -278,6 +278,34 @@ pub trait Dialect: Debug + Any {
false
}
+/// Indicates whether the dialect supports left-associative join parsing
Review Comment:
Very nice thanks for the description!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Fix join precedence for non-snowflake queries [datafusion-sqlparser-rs]
Dimchikkk commented on PR #1905: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1905#issuecomment-3015171544 Thanks for the review, @iffyio - I've addressed your feedback and it’s ready for another round when you are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] Fix join precedence for non-snowflake queries [datafusion-sqlparser-rs]
Dimchikkk opened a new pull request, #1905: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1905 Fixes https://github.com/apache/datafusion-sqlparser-rs/issues/1904. The bug was introduced in https://github.com/apache/datafusion-sqlparser-rs/pull/1799. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
