Re: [PR] chore: Add test to confirm correctness of queries with string predicate filters [datafusion-comet]

2025-05-21 Thread via GitHub 


codecov-commenter commented on PR #1768:
URL: 
https://github.com/apache/datafusion-comet/pull/1768#issuecomment-2898853701

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1768?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 56.17%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`209286f`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/209286fe920c72a80a7d6d90a81dc8078210d639?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 204 commits behind head on main.
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#1768  +/-   ##
   
   + Coverage 56.12%   56.17%   +0.04% 
   - Complexity  976 1052  +76 
   
 Files   119  130  +11 
 Lines 1174312657 +914 
 Branches   2251 2346  +95 
   
   + Hits   6591 7110 +519 
   - Misses 4012 4359 +347 
   - Partials   1140 1188  +48 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1768?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] chore: Add test to confirm correctness of queries with string predicate filters [datafusion-comet]

2025-05-21 Thread via GitHub 


andygrove opened a new pull request, #1768:
URL: https://github.com/apache/datafusion-comet/pull/1768

   ## Which issue does this PR close?
   
   
   
   Part of https://github.com/apache/datafusion-comet/issues/1767
   
   ## Rationale for this change
   
   
   
   Confirm that the Spark SQL test failure is not indicating any kind of 
correctness issue.
   
   ## What changes are included in this PR?
   
   
   
   New test.
   
   ## How are these changes tested?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]