Re: [PR] enable map_values testing since we fall back on nested types for defa… [datafusion-comet]

2025-05-29 Thread via GitHub


mbutrovich commented on PR #1813:
URL: 
https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2919813707

   I thought we were blocked on a DataFusion fix for this. 
https://github.com/apache/datafusion/pull/16203
   
   Maybe I'm getting the map issues mixed up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[PR] enable map_values testing since we fall back on nested types for defa… [datafusion-comet]

2025-05-29 Thread via GitHub


zhuqi-lucas opened a new pull request, #1813:
URL: https://github.com/apache/datafusion-comet/pull/1813

   …ult values
   
   ## Which issue does this PR close?
   
   
   Part of 
   
   Closes [#1789](https://github.com/apache/datafusion-comet/issues/1789)
   
   We should fix map_values when we use native comet again.
   
   ## Rationale for this change
   Now we fall back to Spark for this query in 
https://github.com/apache/datafusion-comet/pull/1799 , we can enable the 
map_values testing.
   
   
   
   ## What changes are included in this PR?
   Now we fall back to Spark for this query in 
https://github.com/apache/datafusion-comet/pull/1799 , we can enable the 
map_values testing.
   
   
   ## How are these changes tested?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]