Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub 


parthchandra merged PR #1925:
URL: https://github.com/apache/datafusion-comet/pull/1925


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub 


andygrove commented on code in PR #1925:
URL: https://github.com/apache/datafusion-comet/pull/1925#discussion_r2164542993


##
native/core/src/parquet/mod.rs:
##
@@ -644,6 +647,26 @@ fn get_file_groups_single_file(
 vec![groups]
 }
 
+pub fn get_object_store_options(
+env: &mut JNIEnv,
+map_object: JObject,
+) -> Result, CometError> {
+let map = JMap::from_env(env, &map_object)?;
+// Convert to a HashMap
+let mut collected_map = HashMap::new();
+// let mut iter = map.iter(&mut env)?;

Review Comment:
   can this commented out code be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub 


parthchandra commented on PR #1925:
URL: 
https://github.com/apache/datafusion-comet/pull/1925#issuecomment-3001134902

   > I have tested it with AWS S3 and it worked fine
   
   Thank you! I managed to test it with S3 as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub 


codecov-commenter commented on PR #1925:
URL: 
https://github.com/apache/datafusion-comet/pull/1925#issuecomment-2998365766

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `0%` with `2 lines` in your changes missing 
coverage. Please review.
   > Project coverage is 32.83%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`2af2464`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/2af2464c38e65eb3720c18ebcf514db58d9f1505?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 279 commits behind head on main.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...va/org/apache/comet/parquet/NativeBatchReader.java](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcomet%2Fparquet%2FNativeBatchReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jb21ldC9wYXJxdWV0L05hdGl2ZUJhdGNoUmVhZGVyLmphdmE=)
 | 0.00% | [2 Missing :warning: 
](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main#1925   +/-   ##
   =
   - Coverage 56.12%   32.83%   -23.30% 
   + Complexity  976  800  -176 
   =
 Files   119  130   +11 
 Lines 1174312757 +1014 
 Branches   2251 2406  +155 
   =
   - Hits   6591 4189 -2402 
   - Misses 4012 7595 +3583 
   + Partials   1140  973  -167 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub 


parthchandra commented on PR #1925:
URL: 
https://github.com/apache/datafusion-comet/pull/1925#issuecomment-2998299473

   @Kontinuation please review if you can.
   (This PR is draft because I haven't been able to test it with S3 yet. The 
unit test passes, though).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub 


parthchandra opened a new pull request, #1925:
URL: https://github.com/apache/datafusion-comet/pull/1925

   #1817 introduced S3A configuration for the `native_datafusion` reader. This 
PR does the same for `native_iceberg_compat`
   
   
   ## How are these changes tested?
   
   Existing unit test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]