Re: [PR] fix: [Iceberg] Fix decimal corruption [datafusion-comet]

2025-07-03 Thread via GitHub


andygrove merged PR #1985:
URL: https://github.com/apache/datafusion-comet/pull/1985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] fix: [Iceberg] Fix decimal corruption [datafusion-comet]

2025-07-03 Thread via GitHub


codecov-commenter commented on PR #1985:
URL: 
https://github.com/apache/datafusion-comet/pull/1985#issuecomment-3033005396

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1985?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 32.72%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`1222ad1`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/1222ad1aac37c95ed2fa87323c0ac98aea440d7e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 308 commits behind head on main.
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main#1985   +/-   ##
   =
   - Coverage 56.12%   32.72%   -23.41% 
   + Complexity  976  799  -177 
   =
 Files   119  133   +14 
 Lines 1174312951 +1208 
 Branches   2251 2411  +160 
   =
   - Hits   6591 4238 -2353 
   - Misses 4012 7759 +3747 
   + Partials   1140  954  -186 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1985?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] fix: [Iceberg] Fix decimal corruption [datafusion-comet]

2025-07-03 Thread via GitHub


hsiang-c commented on PR #1985:
URL: 
https://github.com/apache/datafusion-comet/pull/1985#issuecomment-3032941642

   Thanks @andygrove 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] fix: [Iceberg] Fix decimal corruption [datafusion-comet]

2025-07-03 Thread via GitHub


andygrove commented on PR #1985:
URL: 
https://github.com/apache/datafusion-comet/pull/1985#issuecomment-3032934077

   @hsiang-c fyi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[PR] fix: [Iceberg] Fix decimal corruption [datafusion-comet]

2025-07-03 Thread via GitHub


andygrove opened a new pull request, #1985:
URL: https://github.com/apache/datafusion-comet/pull/1985

   ## Which issue does this PR close?
   
   
   
   Closes #.
   
   ## Rationale for this change
   
   
   
   ## What changes are included in this PR?
   
   
   
   ## How are these changes tested?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]