Re: [PR] fix: Taking slicing into account when writing BooleanBuffers as fast-encoding format [datafusion-comet]
kazuyukitanimura merged PR #1522: URL: https://github.com/apache/datafusion-comet/pull/1522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: Taking slicing into account when writing BooleanBuffers as fast-encoding format [datafusion-comet]
kazuyukitanimura commented on PR #1522: URL: https://github.com/apache/datafusion-comet/pull/1522#issuecomment-2752339224 Thanks @Kontinuation merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: Taking slicing into account when writing BooleanBuffers as fast-encoding format [datafusion-comet]
codecov-commenter commented on PR #1522: URL: https://github.com/apache/datafusion-comet/pull/1522#issuecomment-2719947282 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1522?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 57.82%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`05a4b04`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/05a4b04690267bac46d3beb61ea35b2ae1e9f232?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 74 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1522 +/- ## + Coverage 56.12% 57.82% +1.69% - Complexity 976 985 +9 Files 119 122 +3 Lines 1174312195 +452 Branches 2251 2303 +52 + Hits 6591 7052 +461 + Misses 4012 3960 -52 - Partials 1140 1183 +43 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1522?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). 🚀 New features to boost your workflow: - ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
[PR] fix: Taking slicing into account when writing BooleanBuffers as fast-encoding format [datafusion-comet]
Kontinuation opened a new pull request, #1522: URL: https://github.com/apache/datafusion-comet/pull/1522 ## Which issue does this PR close? Closes #1520. ## Rationale for this change This is a problem I found when working on https://github.com/apache/datafusion-comet/pull/1511, the null bits were not correctly written and caused test failures. This patch is an attempt to fix it. ## What changes are included in this PR? Correctly take slicing indices and length into account when writing BooleanBuffers. This applies to null bits of all arrays, and the values of boolean arrays. ## How are these changes tested? Added a new round-trip test for sliced record batches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
