Re: [PR] fix: cast_struct_to_struct aligns to Spark behavior [datafusion-comet]

2025-06-13 Thread via GitHub 


mbutrovich merged PR #1879:
URL: https://github.com/apache/datafusion-comet/pull/1879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix: cast_struct_to_struct aligns to Spark behavior [datafusion-comet]

2025-06-12 Thread via GitHub 


codecov-commenter commented on PR #1879:
URL: 
https://github.com/apache/datafusion-comet/pull/1879#issuecomment-2967951510

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1879?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 57.64%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`c6fd1e8`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/c6fd1e8422cd75dd00926bdbce69df10f68c76a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 254 commits behind head on main.
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#1879  +/-   ##
   
   + Coverage 56.12%   57.64%   +1.51% 
   - Complexity  976 1089 +113 
   
 Files   119  130  +11 
 Lines 1174312759+1016 
 Branches   2251 2396 +145 
   
   + Hits   6591 7355 +764 
   - Misses 4012 4182 +170 
   - Partials   1140 1222  +82 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1879?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] fix: cast_struct_to_struct aligns to Spark behavior [datafusion-comet]

2025-06-12 Thread via GitHub 


mbutrovich opened a new pull request, #1879:
URL: https://github.com/apache/datafusion-comet/pull/1879

   ## Which issue does this PR close?
   
   
   
   Closes #1875.
   
   ## Rationale for this change
   
   
   
   ## What changes are included in this PR?
   
   
   
   - `cast_struct_to_struct` was modified to support Parquet struct conversion 
before we split that logic off into parquet_support.rs. This brings the cast 
behavior back into alignment with Spark where field names don't matter.
   - Renamed `cast_*` functions in parquet_support.rs and added some 
documentation to better differentiate those two files.
   
   ## How are these changes tested?
   
   
   
   - New test case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]