Re: [PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
parthchandra merged PR #1785: URL: https://github.com/apache/datafusion-comet/pull/1785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
parthchandra commented on PR #1785: URL: https://github.com/apache/datafusion-comet/pull/1785#issuecomment-2917762700 @andygrove @mbutrovich -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
parthchandra commented on PR #1785: URL: https://github.com/apache/datafusion-comet/pull/1785#issuecomment-2916451874 reverted change for field_ids -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
parthchandra commented on PR #1785: URL: https://github.com/apache/datafusion-comet/pull/1785#issuecomment-291761 Also added a small fix for field id types in `native_iceberg_compat` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
codecov-commenter commented on PR #1785: URL: https://github.com/apache/datafusion-comet/pull/1785#issuecomment-2906033714 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `6 lines` in your changes missing coverage. Please review. > Project coverage is 57.15%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fc1a5b8`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/fc1a5b89e2b1199a96d8c842d3959fdc261fe737?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 213 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/1785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...n/scala/org/apache/comet/rules/CometScanRule.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/1785?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Frules%2FCometScanRule.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9ydWxlcy9Db21ldFNjYW5SdWxlLnNjYWxh) | 0.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/1785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1785 +/- ## + Coverage 56.12% 57.15% +1.02% - Complexity 976 1077 +101 Files 119 130 +11 Lines 1174312634 +891 Branches 2251 2365 +114 + Hits 6591 7221 +630 - Misses 4012 4202 +190 - Partials 1140 1211 +71 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1785?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) [datafusion-comet]
parthchandra opened a new pull request, #1785: URL: https://github.com/apache/datafusion-comet/pull/1785 ## Which issue does this PR close? Part of https://github.com/apache/datafusion-comet/issues/1542 Closes #. ## Rationale for this change Encrypted files are not currently supported and cause failure ## What changes are included in this PR? If encryption is enabled, fallback to Spark. ## How are these changes tested? Existing Spark SQL ParquetEncryptionSuite -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
