Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
irenjj commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992587634
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
thanks @Standing-Man , some nitpicks:
For `indent`, we don't need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
alamb merged PR #15194: URL: https://github.com/apache/datafusion/pull/15194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
alamb commented on PR #15194: URL: https://github.com/apache/datafusion/pull/15194#issuecomment-2720841958 Thank you @Standing-Man @2010YOUY01 and @zhuqi-lucas! I merged up from main to resolve a conflict! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
Standing-Man commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1993065283
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -123,8 +123,11 @@ impl DisplayAs for CoalesceBatchesExec {
Ok(())
}
DisplayFormatType::TreeRender => {
-// TODO: collect info
-write!(f, "")
+writeln!(f, "target_batch_size={}", self.target_batch_size)?;
+if let Some(fetch) = self.fetch {
+write!(f, "limit={fetch}")?;
Review Comment:
Yes, you're right. I’ve added a new test to cover `limit` feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
zhuqi-lucas commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992967843
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -123,8 +123,11 @@ impl DisplayAs for CoalesceBatchesExec {
Ok(())
}
DisplayFormatType::TreeRender => {
-// TODO: collect info
-write!(f, "")
+writeln!(f, "target_batch_size={}", self.target_batch_size)?;
+if let Some(fetch) = self.fetch {
+write!(f, "limit={fetch}")?;
Review Comment:
Do we have a explain tree example in slt which with limit? I only see
target_batch_size in the slt testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
irenjj commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992601383
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
Yep, in my opinion, what we change is tree explain format as title
says:`implement tree explain for CoalesceBatchesExec`. And the reason why
commas were added as separators for `indent` is that `indent` format output one
line for every physical plan.
I think it's better to just modify `DisplayFormatType::TreeRender` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
irenjj commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992587634
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
thanks @Standing-Man , some nitpicks:
For `indent`, I think we don't need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
Standing-Man commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992592481
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
Still keep the fetch representation in non-tree rendering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
Standing-Man commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992592481
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
Still keep it as it is? Previously, commas were added as separators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
irenjj commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992587634
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
thanks @Standing-Man , some nitpicks:
For `indent`, I thinks we don't need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] implement tree explain for CoalesceBatchesExec [datafusion]
irenjj commented on code in PR #15194:
URL: https://github.com/apache/datafusion/pull/15194#discussion_r1992587634
##
datafusion/physical-plan/src/coalesce_batches.rs:
##
@@ -117,14 +117,17 @@ impl DisplayAs for CoalesceBatchesExec {
self.target_batch_size,
)?;
if let Some(fetch) = self.fetch {
-write!(f, ", fetch={fetch}")?;
+write!(f, ", limit={fetch}")?;
Review Comment:
thanks @Standing-Man , some nitpicks:
For `indent`, I thinks we shouldn't need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
[PR] implement tree explain for CoalesceBatchesExec [datafusion]
Standing-Man opened a new pull request, #15194: URL: https://github.com/apache/datafusion/pull/15194 ## Which issue does this PR close? - Closes #15141 and Part of #14914. ## Rationale for this change ## What changes are included in this PR? implement tree explain for `CoalesceBatchesExec` ## Are these changes tested? Yes ## Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
