Re: [PR] upgraded spark 3.5.5 to 3.5.6 [datafusion-comet]

2025-06-09 Thread via GitHub 


andygrove merged PR #1861:
URL: https://github.com/apache/datafusion-comet/pull/1861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] upgraded spark 3.5.5 to 3.5.6 [datafusion-comet]

2025-06-08 Thread via GitHub 


YanivKunda commented on PR #1861:
URL: 
https://github.com/apache/datafusion-comet/pull/1861#issuecomment-2954292860

   Rebased latest changes and updated diff file (missing IgnoreComet)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] upgraded spark 3.5.5 to 3.5.6 [datafusion-comet]

2025-06-07 Thread via GitHub 


codecov-commenter commented on PR #1861:
URL: 
https://github.com/apache/datafusion-comet/pull/1861#issuecomment-2952756479

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 32.19%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`7ae4516`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/7ae45163c811840960bf7b534d247257b21568c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 247 commits behind head on main.
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main#1861   +/-   ##
   =
   - Coverage 56.12%   32.19%   -23.93% 
   + Complexity  976  651  -325 
   =
 Files   119  130   +11 
 Lines 1174312659  +916 
 Branches   2251 2359  +108 
   =
   - Hits   6591 4076 -2515 
   - Misses 4012 7791 +3779 
   + Partials   1140  792  -348 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1861?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] upgraded spark 3.5.5 to 3.5.6 [datafusion-comet]

2025-06-06 Thread via GitHub 


YanivKunda opened a new pull request, #1861:
URL: https://github.com/apache/datafusion-comet/pull/1861

   ## Which issue does this PR close?
   
   
   
   Closes #1857
   
   ## Rationale for this change
   
   Spark 3.5.6 is the latest stable 3.5.x version, and should be supported.
   
   
   
   
   ## What changes are included in this PR?
   
   Just the upgrade of spark 3.5.5 to 3.5.6.
   The `ShimCometScanExec` changes done for the 3.5.4 -> 3.5.5 upgrade in 
https://github.com/apache/datafusion-comet/pull/1565 and 
https://github.com/apache/datafusion-comet/pull/1573 still work because the 
referenced spark code hasn't changed. 
   
   
   
   ## How are these changes tested?
   
   Ran `mvn test` with the `spark-3.5` profile.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]