Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-3490387309 8 months of work, but we did it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
xudong963 commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-3490360447 🎊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb closed issue #15178: [Epic] Add snapshot tests (migrate to `insta` for tests) URL: https://github.com/apache/datafusion/issues/15178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-3180654895 We have only https://github.com/apache/datafusion/issues/15791 left -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-3180654273 we are so close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
xudong963 commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2989610772 https://github.com/apache/datafusion/blob/5ca4ff02932eecdd203b1b90acaf4381c0d5cb5c/datafusion/proto/tests/cases/roundtrip_physical_plan.rs#L143 I think the roundtrip tests also can use insta? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
xudong963 commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2813142044 Places are still using old styles: - [ ] core/tests/sql/explain_analyze.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
blaginin commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2813832937 for sure, will do! thank you!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2813827406 @blaginin any chance you could file some good first issue tickets to cover the places taht @xudong963 identified in https://github.com/apache/datafusion/issues/15178#issuecomment-2813142044 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
alamb commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2730830528 > [@alamb](https://github.com/alamb) can I ask you to put "good first issue" on tickets in the list if you're happy with them? I don't think I have permission to do that Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
blaginin commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2726487177 @alamb can I ask you to put "good first issue" on tickets in the list if you're happy with them? I don't think I have permission to do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
blaginin commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2726480816 Those places may be good to check https://github.com/user-attachments/assets/1dfd4de9-131f-4244-8f08-8647fe3c2d13"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [Epic] Add snapshot tests (migrate to `insta` for tests) [datafusion]
shruti2522 commented on issue #15178: URL: https://github.com/apache/datafusion/issues/15178#issuecomment-2723169995 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
