Re: [I] Document `CREATE EXTERNAL TABLE ... OPTIONS` [datafusion]

2025-12-23 Thread via GitHub


Jefffrey closed issue #10451: Document `CREATE EXTERNAL TABLE ... OPTIONS`
URL: https://github.com/apache/datafusion/issues/10451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Document `CREATE EXTERNAL TABLE ... OPTIONS` [datafusion]

2025-04-12 Thread via GitHub


alamb commented on issue #10451:
URL: https://github.com/apache/datafusion/issues/10451#issuecomment-2798883874

   Hi @marvelshan  -- I also took a look at the docs. It actually looks like 
the format options are largely documented, but the documentation could be 
improved
   
   I suggest:
   
   1. Rename 
[`write_options.md`](https://datafusion.apache.org/user-guide/sql/write_options.html)
 to `format_options.md` and make it clear they apply both to reading and 
writing . Also, link `write_options` clearly in the `CREATE EXTERNAL TABLE` 
section
   
   2. Then for each sub heading for each format (`JSON format specific 
options`, etc) add an example, such as 
   
   ```sql
   CREATE EXTERNAL TABLE t 
   STORED AS JSON
   LOCATION '/tmp/foo.dat'
   OPTIONS('COMPRESSION', 'bzip')
   ```
   
   I also suggest increasing the level of Json, csv, etc options so they appear 
in the table of contents
   
   
![Image](https://github.com/user-attachments/assets/2c3f3418-9c03-4079-a679-b516ef492b2d)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Document `CREATE EXTERNAL TABLE ... OPTIONS` [datafusion]

2025-04-11 Thread via GitHub


marvelshan commented on issue #10451:
URL: https://github.com/apache/datafusion/issues/10451#issuecomment-2798494312

   Before proceeding with implementation, I'd like to confirm my approach is 
correct. I'm planning to create a new file named `options.md`dedicated to 
documenting the available options for the OPTIONS clause.
   
   Rationale:
   Current documentation gap: The existing `ddl.md` only briefly introduces the 
basic syntax of CREATE EXTERNAL TABLE without detailed explanations of the 
OPTIONS clause.
   
   Different focus in existing files: While `write_options.md` does cover some 
options related to COPY and INSERT INTO operations, its focus is different from 
what's needed for comprehensive OPTIONS clause documentation.
   
   Clearer organization: A new dedicated file would provide complete 
documentation for the OPTIONS clause without confusing users by mixing it with 
other command documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Document `CREATE EXTERNAL TABLE ... OPTIONS` [datafusion]

2025-04-11 Thread via GitHub


marvelshan commented on issue #10451:
URL: https://github.com/apache/datafusion/issues/10451#issuecomment-2797584011

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]