Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-16 Thread via GitHub


alamb closed issue #14072: Move `SanityChecker` into 
`datafusion-physical-optimizer` crate
URL: https://github.com/apache/datafusion/issues/14072


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-11 Thread via GitHub


cj-zhukov commented on issue #14072:
URL: https://github.com/apache/datafusion/issues/14072#issuecomment-2585575154

   > > @mnpw OK, to avoid such situation in the future, please be attentive in 
following the rules
   > 
   > FWIW the guidelines are here: 
https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets
   > 
   > TLDR it is polite (but not required) to give a heads up on the ticket
   
   Andrew, thanks for the clarification and sharing the guidelines! I’ll keep 
this in mind going forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-11 Thread via GitHub


alamb commented on issue #14072:
URL: https://github.com/apache/datafusion/issues/14072#issuecomment-2585345199

   > @mnpw OK, to avoid such situation in the future, please be attentive in 
following the rules
   
   FWIW the guidelines are here: 
   
https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets
   
   TLDR it is polite (but not required) to give a heads up on the ticket


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-10 Thread via GitHub


mnpw commented on issue #14072:
URL: https://github.com/apache/datafusion/issues/14072#issuecomment-2585112045

   @cj-zhukov Apologies, I started working on this PR without explicitly 
assigning it to myself. Would appreciate your review on 
https://github.com/apache/datafusion/pull/14083.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-10 Thread via GitHub


alamb commented on issue #14072:
URL: https://github.com/apache/datafusion/issues/14072#issuecomment-2583265249

   Thanks @cj-zhukov !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Move `SanityChecker` into `datafusion-physical-optimizer` crate [datafusion]

2025-01-10 Thread via GitHub


cj-zhukov commented on issue #14072:
URL: https://github.com/apache/datafusion/issues/14072#issuecomment-2582906768

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]